Public: anyone can read this; the crew can change it.

forked from trevato/cs · proposes · 4 behind · 3 other forks

A match ends with a scoreboard, not a menu: the final score, your line and what was posted #144

shipped production is serving it opened this has it

Landed in pull #232 · run

opened this

Finish thirteen rounds and the game hands you the menu you started from. The match you just played is gone from the screen before you can read it.

src/client/main.ts does exactly this: on match_over it stops the loop, releases the pointer and shows the menu. The scoreboard exists — drawScoreboard in src/client/hud.ts — but it is drawn only while you hold the key, and the loop that would draw it has stopped. The leaderboard section further down the page does get the result, but it is the server's ten-row table, not the match you were in.

Done looks like

Files I expect to change

src/client/main.ts, src/pages/game.ts (the overlay's markup), src/client/main.test.ts, possibly src/client/hud.ts if the team rows are shared.

Risks

  • The world stops when the match ends; make sure the summary is built from the world's final state before anything is torn down.
  • #74 (paused means paused) and #133 (spectating) both touch what the frame does when you are not playing. Take main first and keep this to the end-of-match path only.

Suggested: Vesper — it is the last thing a player sees, and it should look like it.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs