A thread folds its settled history (#13003)
An issue's or a pull's conversation opens on what still needs someone: the opening post, the newest comment and whatever followed it, every question still waiting for its answer, and the composer. The settled history before the newest comment sits in plain <details class="tl-fold"> folds, each with its counts on the summary ("49 earlier comments · 3 events").
- What stays out of a fold: the newest comment and everything after it, and any entry marked
open(Entry.open,src/web/pages/thread.ts). On a pull that is a request for changes that is its reviewer's newest verdict while the pull is open (standingRequests,src/web/studio/change.ts). A later plain comment from that reviewer does not withdraw it. An approval does. A standing entry splits the history into one fold before it and one after it. A run of fewer than two settled entries is not folded. - Resolved line threads on Files already collapse to one line on their own (
src/web/diff-view.ts). Issue comments have no thread or resolution state, so for an issue the newest comment is the visible question. - Long threads: past the newest 50 comments (8 on a pull,
threadWindow) the page still links?all=1("Show N earlier items"). The fold only covers what is on the page. - Deep links:
#c-<id>to a folded comment opens its fold and scrolls to it (src/web/fold.ts, appended toshellJs; it readslocationonly on a page that has a fold, and opens again onhashchange). - Without JavaScript:
.tl-fold:has(:target)::details-content { content-visibility: visible; }shows a fold's content while the linked comment is inside it. That needs:has()and::details-content: Chrome/Edge 131+, Safari 18.4+, Firefox 143+. In an older browser with script off, the link lands on the closed fold, and the comment is one click on its summary away. Nobody has checked this rule in a real browser yet. The test only checks that the rule ships. - Terminal and MCP: rendering only. The terminal and the API return whole threads, so they have nothing to fold.
- Tests:
test/thread-window.test.ts.
A pull opens on a summary and a filmstrip (#13654)
The top of a pull page, above any thread: the title, the one verdict, a summary beside a filmstrip, then the actions. Nothing there grows with the thread.
- Summary. The first sentences of the builder's description (markdown and headings stripped, 320 characters at most,
changedSentencesinsrc/core/pulls.ts), with a link to the notes. What was verified is the verdict line's, not said twice. Nothing is stored: it is read each time.src/web/pages/pull-verdict.ts. - Filmstrip. The current head's pictures as one player (
src/web/pages/filmstrip.ts): main's picture before the head's, stepping through pages, widths and themes, 24 frames at most, each with its caption. It opens still on the first frame; Previous, Next, Before ⇄ after and Play step it (Play pauses on hover or focus). The stage takes the first picture's ratio, so nothing is clipped and nothing shifts, on a phone too. A click opens the full-size picture. Without script the first frame shows. Older commits' pictures are not on the page:?looks=allopens the full block. - Thread. A pull's page carries the opening post and the newest 8 comments (
PULL_THREAD_WINDOW; an issue keeps 50); older ones are one link away (?all=1,thread-fold.md). - MCP.
pullreturnssummaryfirst (what changed, then what the check said) and the newest 10 comments; older ones bycommentsNext. - Terminal. The pull screen's verdict row carries what changed after the verdict.
- Not done: loading older entries in place, search within a thread, per-round gists, the issue page's standing line (#13641).
- Tests:
test/filmstrip.test.ts,test/thread-window.test.ts.