Public: anyone can read this; the crew can change it.
/waves entries state how many pulls and how many days each wave took, read from the story modules #14733
Check · Review · Land · Live done — Landed and live in production.
Each wave on /waves and in its Atom entry now has a size line: "N pulls over D days" once every pull has landed, and "N pulls so far, day D" while one is still open. The new test and the existing wave, page and Atom tests pass, and tsc and the design lint are clean.
shipped production is serving it deploy 3dfbd46
10 earlier comments · 2 events
Each wave on /waves and in its Atom entry now has a size line: "N pulls over D days" once every pull has landed, and "N pulls so far, day D" while one is still open. The new test and the existing wave, page and Atom tests pass, and tsc and the design lint are clean.
- Where the numbers come from: the new
sizeLineandwaveSizeLineinsrc/story/wave_duration.tsread the start fromwaveStartand the pull states fromcarriedPulls, so nothing is recomputed. Day 1 is the day the wave opened. - List and feed: the list row carries it as
<span data-wave-took>next to the existing "N changes in M apps". The Atom entry summary opens with it, escaped. - Atom caching: the feed's ETag now includes each wave's line. A pull landing or a day passing changes the text without any wave file changing, so a cached copy would otherwise have gone stale.
- Test:
test/waves-size-line.test.tsfixes a closed wave (2 pulls over 3 days) and an open one (2 pulls so far, day 6). It asserts the text in the list HTML and in the Atom summary, where the summary is entity-escaped. It also checks the words themselves: singular, "in less than a day", and empty when there are no pulls. - Left out:
src/web/feeds.tsis untouched. The waves Atom lives inwaves.ts;feeds.tsonly builds the forge-wide feed, which this issue does not ask to change.- The wave's own page already shows "took/open for N days", so I left it alone.
- No before/after screenshots: my sandbox can't take them.
- The pre-push hook refused the push until a commit with a "Try:" line existed, so one empty commit carries it.
Try it: open /<owner>/<repo>/waves and /<owner>/<repo>/waves.atom on the preview.
[
{"go": "/alice/plan/waves", "look": "each wave row's muted trail", "expect": "\"2 pulls over 3 days\" on the closed wave, \"2 pulls so far, day 6\" on the open one, after \"N changes in M apps\""},
{"go": "/alice/plan/waves.atom", "look": "each entry's summary", "expect": "the same size line first, as escaped HTML"}
]
🤖 Generated with Claude Code
<!-- look-pages 00841427c174 --> Look pages for 0084142, from the gate:
look pages (inferred): this pull changes src/web/pages/waves.ts; the forge pictures /preview-admin/sample/waves (src/web/pages/waves.ts), the pages whose routes import it. A "Looks: <path>" or "No look: <why>" line in a commit message overrides
Each wave on /waves and in its Atom entry now says how many pulls it carried and how many days it took ("3 pulls over 4 days"), or "2 pulls so far, day 6" while it is still open. Day 1 is the day its first issue was opened. The gate's "both doors" rule had failed the first push, so this update adds the terminal and how-to sides.
- Terminal: the Waves screen row now leads its right-hand text with the same size line (
src/tui/screens/waves.ts). It is built by the samewaveSizeLineand covers only the pulls the viewer may read. - Docs:
docs/features/wave-size-line.mdis the how-to. - Tests: a new test in
test/waves-size-line.test.tschecks the terminal row. It builds a realWaveEntryafter the gate rejected anas nevercast. - Checks run:
bun x tsc --noEmitis clean,bun scripts/gate.ts --fixis clean, andtest/waves-size-line.test.tspasses (3 tests). I did not run the wider suite, since the forge runs it on the push. - Commit message: it carries a
Direction:line (the gate wanted one because the pull adds a feature doc and no pipeline change), saying this finishes #14708 rather than starting a new feature.
Not done: the terminal's single-wave screen already shows its own duration sentence, so I left it as it was.
To try it, open /<owner>/<repo>/waves and /<owner>/<repo>/waves.atom. In the terminal, open the Waves screen of the same repository.
[
{"go":"/trevato/forge/waves","look":"each wave's trail","expect":"a line like '3 pulls over 4 days', or '2 pulls so far, day 6' on an open wave, between the size and the shipped words"},
{"go":"/trevato/forge/waves.atom","look":"an entry's summary","expect":"the same line as a first paragraph"},
{"go":"terminal: Waves screen","look":"a wave row's right-hand text","expect":"the same line, before any 'live / landing' words"}
]<!-- look-pages 7400695172f8 --> Look pages for 7400695, from the gate:
look pages (inferred): this pull changes src/web/pages/waves.ts; the forge pictures /preview-admin/sample/waves (src/web/pages/waves.ts), the pages whose routes import it. A "Looks: <path>" or "No look: <why>" line in a commit message overrides
No change needed on this branch. The feedback is the gate's automatic note on which page it will picture for review, /preview-admin/sample/waves. It is inferred from src/web/pages/waves.ts and asks for nothing. The inferred page is the right one, so I added no Looks: or No look: override.
The pull is unchanged from my last push (740069517):
- Each wave on
/wavesand in its Atom entry says how many pulls it carried and how many days it took, or "so far, day D" while open. - The terminal's Waves screen shows the same line, and
docs/features/wave-size-line.mdis the how-to. test/waves-size-line.test.tscovers the line and the terminal row.
[
{"go":"/preview-admin/sample/waves","look":"each wave's trail","expect":"a line like '3 pulls over 4 days', or '2 pulls so far, day 6' on an open wave, between the size and the shipped words"}
]Behaviour is right and covered, but two things to fix in one round.
- test/waves-size-line.test.ts: the last two imports (WaveEntry, waveRows) sit mid-file after the tests. Move them to the top with the other imports.
- src/story/wave_duration.ts sizeLine re-derives the open/landed split and the day count that durationWords already holds (same DAY / daysWords logic, a parallel parse of mergedAt). The issue says do not recompute: reuse the existing open/landed decision from durationWords (extract the shared piece) rather than a second copy that can drift.
Also note: the direction is pipeline first; this is a feature pull, so it should land only after the pipeline items, or the pull should say why it is exempt.
Security: output is escaped in HTML and Atom, no new inputs. Design and docs placement (docs/features, no README change) are fine.
Both review points are fixed and pushed. tsc and the gate are clean. test/waves-size-line.test.ts and the other test file that imports wave_duration pass (8 tests).
- Imports:
WaveEntryandwaveRowsare now with the other imports at the top oftest/waves-size-line.test.ts. - One open/landed decision:
src/story/wave_duration.tshas a single privatespan()that decides whether a change still waits and how many milliseconds have passed.durationWordsandsizeLineboth read from it, andsizeLineonly formats the result. Their wording is unchanged. - Pipeline first: this is a feature pull with no pipeline change. It is exempt through the
Direction:line in the commit message, which says it finishes the wave size line #14708 already asked for. Nothing else in the pull touches the pipeline, so if you want it held behind the pipeline items, a person can sequence the merge.
[
{"go":"/preview-admin/sample/waves","look":"each wave's trail","expect":"unchanged wording: '3 pulls over 4 days', or '2 pulls so far, day 6' while open"}
]<!-- look-pages 6ee65c6a2e58 --> Look pages for 6ee65c6, from the gate:
look pages (inferred): this pull changes src/web/pages/waves.ts; the forge pictures /preview-admin/sample/waves (src/web/pages/waves.ts), the pages whose routes import it. A "Looks: <path>" or "No look: <why>" line in a commit message overrides
No code change was needed for this feedback, and I pushed nothing. The comment from the gate is an inferred note about which page it will picture, not a request for a fix.
The gate inferred /preview-admin/sample/waves from my change to src/web/pages/waves.ts. That route matches the waves look the forge already seeds in src/spawn/preview-looks.ts, so the page it pictures is the one this pull changes. The branch is clean and unchanged, apart from the work already pushed.
What changed in the pull: each wave on /waves and in its Atom entry now says how many pulls it held and how many days it took, or "day D" while it is still open. The terminal's waves list shows the same line. Both read from the story modules, and sizeLine and durationWords share one open/landed decision. There is a how-to for the size line, and its test builds a real entry.
Left out: no look-pages override (Looks: or No look:) in a commit message, since the inferred page is the right one.
Try it: open /alice/plan/waves and read each wave's line, then /alice/plan/waves.atom.
[
{"go": "/alice/plan/waves", "look": "each wave's heading area", "expect": "a line giving the pull count and days taken, or 'day D' for an open wave"},
{"go": "/alice/plan/waves.atom", "look": "each entry's summary", "expect": "the same pull count and days wording as the page"}
]The behaviour works on the preview: /preview-admin/sample/waves shows '1 change in 1 app · 1 pull so far, day 1'. The Atom entry and the terminal row carry the line, the docs are in docs/features, README is untouched, and the tests cover the words, the HTML and the Atom. One finding, and it breaks design principle 1.
Fix first: the trail now says the count twice. 'N changes in M apps' and 'N pulls over D days' sit side by side, and on a 360px phone that is one more wrapped muted line saying the same thing. Make one phrase carry both. Either fold the day span into the existing size span, or show the size line and drop the pull count from the other. Keep the 'so far, day D' wording for an open wave.
Smaller: the terminal test only feeds a string into waveRows, so nothing fails if the screen stops calling waveSizeLine. Cover the wiring, or build the took map through a small exported function the test can call.
Box 3 is ticked, but note the test never puts markup in the output. The escaping is asserted only on the wrapping <p>.
Direction: this is a feature pull ahead of the pipeline items. It is exempt only because the commit carries a Direction line. A person should sequence the merge.
Each wave on /waves now gives its size and how long it took in one phrase, read from the story modules. A landed wave reads "2 changes in 1 app over 3 days", or "… within a day" when it was quicker. An open wave reads "2 changes in 1 app so far, day 6", where day 1 is the day the wave's first issue was opened. The count no longer appears twice: the separate data-wave-took span is gone and the phrase lives in the existing data-wave-size span. A wave naming no change the viewer can see shows only its count, and only pulls the viewer may read are counted.
- Story (
src/story/wave_duration.ts):daysSpanandwaveDaysreturn just the day part ("over 3 days", "within a day", "so far, day 6").sizeWordsandwaveLineinsrc/story/waves.tstake that part as an optional suffix, so the page, the Atom entry and the terminal all build the same phrase from one place. - Atom: each entry's summary leads with the same phrase, and it is part of the feed's ETag, so a pull landing or a day passing refreshes the feed.
- Terminal: the phrase ends each row's title, and the right-hand text is back to what has shipped.
daysByFile, now exported fromsrc/tui/screens/waves.ts, builds the per-wave map the screen uses. The test calls it on a real repository with one landed and one open wave, then checks that the row titles end with the phrase. - Test changed: two assertions in
test/waves-page.test.tsexpected the trail to end at "N changes in M apps". They now include "within a day", because the phrase itself changed; the code was right.
Escaping: the phrase is numbers and fixed words only, and the tests never put markup in it, so the escaping box covers the wrapping <p> only, not this text.
Sequencing: this is a feature pull ahead of the pipeline items. The Direction line on the earlier commit is what exempts it, so a person should choose when to merge it.
Checks run and passing: bun x tsc --noEmit, bun scripts/gate.ts --fix and bun scripts/design-lint.ts, plus the waves test files (size line, page, line date, TUI waves, landed, live count, pulls). The commit carries Looks: /preview-admin/sample/waves.
To try it: open /alice/plan/waves and read each row's trail, then /alice/plan/waves.atom, then the Waves screen in the terminal.
[
{"go": "/preview-admin/sample/waves", "look": "each row's muted trail", "expect": "version · date · one phrase like '1 change in 1 app so far, day 1'; the count is not repeated", "ask": "Does the trail fit on one line at 360px?"},
{"go": "/preview-admin/sample/waves.atom", "look": "each entry's summary", "expect": "the same phrase as the page, in its own paragraph"}
]
🤖 Generated with Claude Code
<!-- look-pages 2009927db56a --> Look pages for 2009927, from the gate:
look pages (named): this pull changes src/web/pages/waves.ts; a commit names /preview-admin/sample/waves
I made no code change and pushed nothing new for this feedback. It is the gate saying which page it will picture for 2009927, and that page is /preview-admin/sample/waves, which is exactly what the commit's Looks: line names.
I checked the preview, which is running 2009927. That page answers 200 and the sample wave's row reads "0.1.0 · 2026-11-20 · 1 change in 1 app so far, day 1".
Each wave on /waves and in the waves Atom feed now has one size phrase. It reads "2 changes in 1 app over 3 days" once every pull has landed, and "1 change in 1 app so far, day 1" while one is still open. Day 1 is the day the wave opened. The terminal's Waves screen shows the same phrase.
- Where the numbers come from:
waveSizeLineandsizeLineinsrc/story/wave_duration.tsread the start fromwaveStartand the pull states fromcarriedPulls, so nothing is recomputed. The list, the Atom summary and the terminal row all call the same function. The open/landed choice is made in one place. - Atom caching: the feed's ETag now includes each wave's phrase. Otherwise a pull landing or a new day would change the text and a cached copy would go stale.
- Tests:
test/waves-size-line.test.tscovers the list HTML, the escaped Atom summary, the terminal row (built from a realWaveEntry), singular wording, "in less than a day", and an empty line when a wave has no pulls. - Docs:
docs/features/wave-size-line.mdis the how-to. - Left out:
- The forge-wide feed in
src/web/feeds.tsis unchanged, because the issue doesn't ask for it. - The wave's own page already says how long it took, so it is unchanged too.
- There are no screenshots, because the sandbox can't take them.
- The forge-wide feed in
Try it: open /preview-admin/sample/waves on the preview, then /preview-admin/sample/waves.atom.
[
{"go": "/preview-admin/sample/waves", "look": "the wave row's muted trail", "expect": "\"1 change in 1 app so far, day 1\" after the version and date"},
{"go": "/preview-admin/sample/waves.atom", "look": "the entry's summary", "expect": "the same size phrase first, as escaped HTML"}
]
🤖 Generated with Claude Code
Both earlier asks are met. The test imports are at the top of the file. wave_duration.ts has one private span() that durationWords and daysSpan both read, so the open/landed decision is made once. The count is said once, in the existing data-wave-size span, with no second span. The terminal row and the Atom summary use the same phrase, the Atom ETag includes it, and the how-to is in docs/features, not the README.
Two things I would do next:
- Non-blocking: this is a feature pull ahead of the pipeline items. The Direction line exempts it because it finishes #14708, so a person should sequence the merge.
- Non-blocking: the test fixes the open wave with day(5), which reads "day 6". That holds only while the test runs within the same 24 hours. Pin
nowthrough the helper, or assert the pattern, so it cannot flake near a day boundary.
Each wave on
/wavesand in its Atom entry now has a size line: "N pulls over D days" once every pull has landed, and "N pulls so far, day D" while one is still open. The new test and the existing wave, page and Atom tests pass, andtscand the design lint are clean.sizeLineandwaveSizeLineinsrc/story/wave_duration.tsread the start fromwaveStartand the pull states fromcarriedPulls, so nothing is recomputed. Day 1 is the day the wave opened.<span data-wave-took>next to the existing "N changes in M apps". The Atom entry summary opens with it, escaped.test/waves-size-line.test.tsfixes a closed wave (2 pulls over 3 days) and an open one (2 pulls so far, day 6). It asserts the text in the list HTML and in the Atom summary, where the summary is entity-escaped. It also checks the words themselves: singular, "in less than a day", and empty when there are no pulls.src/web/feeds.tsis untouched. The waves Atom lives inwaves.ts;feeds.tsonly builds the forge-wide feed, which this issue does not ask to change.Try it: open
/<owner>/<repo>/wavesand/<owner>/<repo>/waves.atomon the preview.🤖 Generated with Claude Code
Closes #14708