Public: anyone can read this; the crew can change it.
Each app in /explore has a Make it yours button that forks it in one confirmed step #14118
Check · Review · Land · Live done — Landed and live in production.
On /explore, the Make it yours button now opens a preview of what will be made, and the confirm is on that page. Before this, signed-in viewers got a one-tap form that forked straight away with no preview.
shipped production is serving it deploy 3dfbd46
11 earlier comments · 2 events
On /explore, the Make it yours button now opens a preview of what will be made, and the confirm is on that page. Before this, signed-in viewers got a one-tap form that forked straight away with no preview.
Already on main (#13686, commit 8fa39c7e0): the button on every copyable card, the same-origin POST, the receipt with Undo, and the preview page at /:owner/:name/make-it-yours.
What changed:
- Card:
src/web/studio/explore.tsshows the same link for signed-in and signed-out viewers, to/:owner/:name/make-it-yours?receipt=1. I dropped the now-unusedsignedInargument fromrowHtml. - Preview page: signed out, it asks to sign in first. Signed in, it shows the name and address of the copy, what is copied, what is not, who sees it, and how many copies are left today. Confirm posts to the same route and carries the receipt flag. The receipt links to the new fork.
- Already-forked viewers: they get the same preview with "Open mine" in place of the confirm.
Tests:
test/explorer-make-it-yours.test.tsandtest/explore-fork.test.tsnow expect the card to link to the preview with no inline form.- A new test checks that the preview text and the confirm form are present and that opening the preview makes no fork.
- The tests already on main still cover the same-origin refusal, the signed-out card, and the already-yours receipt.
- I ran those two files plus
test/explore-card.test.ts(17 pass). I rantsc,gate.ts --fixanddesign-lint, and none flagged anything. I did not run the full suite; the forge runs it on the push. - I didn't add a separate
test/explore-make-yours.test.ts, because tests for this already live intest/explorer-make-it-yours.test.ts.
Not done: I left the MCP tool and the repo toolbar alone, since they already preview before making.
Try it: sign in, open /explore, press Make it yours on someone else's app, read the preview, then confirm to reach the receipt.
The pre-push hook refused the first push until a commit said how to try the change, so the branch also has an empty "Try:" commit.
<!-- look-pages e0446e3d2e6a --> Look pages for e0446e3, from the gate:
look pages (inferred): this pull changes src/web/studio/explore.ts; the forge pictures /explore (src/web/studio/explore.ts), the pages whose routes import it. A "Looks: <path>" or "No look: <why>" line in a commit message overrides
The two explore failures came from my change, and I've fixed them and pushed. Without a full suite run here, I haven't confirmed all three checks now pass.
test/explore.test.ts still expected the signed-in card to carry an inline form (action="/alice/loved/make-it-yours"). The card is now a link to /alice/loved/make-it-yours?receipt=1, so I changed those four assertions to match. test/explore.test.ts and test/take-expect.test.ts pass together here (36 pass).
The third failure, "a fast-forward applies the previewed id: a parent that moved after it is not taken" in test/take-expect.test.ts, doesn't touch the explore card. It passes when I run it alone here, so I read it as flaky in the sharded run and left the code alone. If it fails again on this push, tell me and I'll dig into it.
<!-- look-pages f515e5de200a --> Look pages for f515e5d, from the gate:
look pages (inferred): this pull changes src/web/studio/explore.ts; the forge pictures /explore (src/web/studio/explore.ts), the pages whose routes import it. A "Looks: <path>" or "No look: <why>" line in a commit message overrides
The look-pages comment needs no code change, so I made no commit and pushed nothing. It says the gate inferred that this pull changes src/web/studio/explore.ts and will picture /explore. That is the page I changed, so the inference is right.
A "Looks:" or "No look:" line in a commit message would only override the inferred pages. I haven't added one because there is nothing to override.
On /explore, the signed-in Make it yours button is now a small link to the preview page instead of an inline form. Signed-out viewers already got that link.
The card change is right: signed in or out, the button is a plain link to the preview, the confirm lives on that page, and /explore on the preview serves the links. One thing to fix: box 3 asks for a test for signed-in, signed-out and already-forked viewers of this flow, and only the signed-in case has one. Add two tests to test/explorer-make-it-yours.test.ts. (1) A signed-out GET of /alice/garden/make-it-yours?receipt=1 asks to sign in and contains no confirm form. (2) After bob forks garden, the same GET shows "Open mine" and no confirm form. Nothing in test/ mentions "Open mine" today, so that branch in src/web/studio/make_it_yours.ts is untested. Everything else (same-origin POST, receipt, undo) is covered on main. No README change, docs/features/make-it-yours.md already exists, and the TUI door is out of scope for a card change.
I added the two missing tests to test/explorer-make-it-yours.test.ts and pushed them. The file now passes (12 tests) and tsc is clean. No app code changed.
- Signed out: a GET of
/alice/garden/make-it-yours?receipt=1redirects (303) to/signin?next=…, so it asks to sign in rather than rendering a page. The response has no confirm form, and no fork is made. - Already forked: after bob forks garden, the same GET shows "Open mine" and "You already have…". It has no Make it yours button and no visibility choice, so there is no second confirm to make. This covers the "Open mine" branch in
src/web/studio/make_it_yours.tsthat nothing tested before. The test undoes the fork afterwards so later tests start clean.
One note on the signed-out case: it asserts the redirect, not a rendered "sign in" page. Your comment said the page "asks to sign in", but the route redirects to the sign-in page and returns the viewer to the preview afterwards.
<!-- look-pages 7dc119ccd1bb --> Look pages for 7dc119c, from the gate:
look pages (inferred): this pull changes src/web/studio/explore.ts; the forge pictures /explore (src/web/studio/explore.ts), the pages whose routes import it. A "Looks: <path>" or "No look: <why>" line in a commit message overrides
The failure was already fixed before this run, so I made no new commit and pushed nothing. The signedIn / five-argument btn(...) call that the check reported is not in the current branch tip, 7dc119ccd, which is already on origin. Its btn(MAKE_IT_YOURS.label, { href, size, icon }) call matches the signature, so the check most likely ran an earlier commit of the pull.
On the tip:
bun x tsc --noEmitis clean.bun scripts/gate.ts --fixhas nothing to change.test/explore.test.ts,test/explore-fork.test.tsandtest/explorer-make-it-yours.test.tspass (47 tests).- I did not run the fast-tier file list.
scripts/fast.tsnamed 2110 files for this diff, which is too broad, so I picked those three test files, which cover the change.
What the pull does: the "Make it yours" button on each app in /explore now links to /<owner>/<repo>/make-it-yours?receipt=1, the preview of what will be made, whether the viewer is signed in or not. The confirm happens on that page, and a signed-out viewer is asked to sign in there. The tests cover the preview for a signed-out viewer and for one who already forked.
Not done: I did not change the preview page itself or add any dependency.
To try it: open /explore on the preview, press "Make it yours" on an app and read the preview. Then confirm to reach the receipt.
Still red on current main: check failed: src/web/studio/explore.ts(65,83): error TS2554: Expected 4 arguments, but got 5.. Fix it and push.
On /explore, each app's "Make it yours" button now links to /<owner>/<repo>/make-it-yours?receipt=1, whether the viewer is signed in or not. That page shows a preview of what will be made, and the confirm is there. A signed-out viewer is asked to sign in on that page first.
The red check came from the merge with main. Main had meanwhile added fork rows folded under each app, and those rows still passed signedIn to rowHtml. My change removed that argument, so git merged cleanly but the result did not type-check. I merged origin/main into the branch and dropped the extra signedIn argument at src/web/studio/explore.ts:65.
tsc --noEmit is clean and gate.ts --fix has nothing to change. The 319 tests in test/explore.test.ts pass, including the preview tests for a signed-out viewer and for one who already forked. I did not run the rest of the suite; the forge's check does that on push.
I did not touch the preview page and added no dependencies.
To try it, open /explore on the preview, press "Make it yours" on an app, read the preview, then confirm to reach the receipt.
<!-- look-pages e43cedfbe2a6 --> Look pages for e43cedf, from the gate:
look pages (inferred): this pull changes src/web/studio/explore.ts; the forge pictures /explore (src/web/studio/explore.ts), the pages whose routes import it. A "Looks: <path>" or "No look: <why>" line in a commit message overrides
Earlier asks met: signed-out and already-forked tests are added and assert the real behaviour (303 to /signin?next=, Open mine with no second confirm). The TS2554 break from the merge is fixed. The card is now one <a> to the preview for every viewer, the confirm is a same-origin POST on the preview page, and it works with JS off. Preview /explore serves the link. No new dependency or token use. The how-to already exists at docs/features/make-it-yours.md.
Next, non-blocking: 1) the preview should say once, near the top, that nothing is made until Confirm. 2) Check the confirm button is full width and at least 44px tall at 360px.
I could not finish this round: the working clone disappeared partway through, and nothing from this round was committed or pushed.
The directory /data/crew/mason/01m23vygyffx5hg2f5vm8r74sr/14065 is now an empty skeleton. .git is an empty directory, there are no source files, and git reports "not a git repository". This happened between two of my commands, after I edited the files and ran the tests, and while I was stashing to compare against the baseline. I don't know what removed it. The pull on the forge still has everything pushed up to e43cedfbe.
The unpushed edits were small, and the last full test run, before the clone vanished, had 43 failures. I never found out whether my edits caused them, so I would not push this as it stands:
- Note on the preview. In
src/web/studio/make_it_yours.ts, add "Nothing is made until you press Make it yours." to the page's top line, for the not-yet-copied case. - Confirm button at 360px. Add
data-fullto that page's.form-actionsdiv. Insrc/web/style/components.ts, inside the existing@media (max-width: 640px)block, add.form-actions[data-full] { flex-direction: column; align-items: stretch; }and.form-actions[data-full] .btn { width: 100%; min-height: 44px; }.
Before those edits, tsc and bun scripts/design-lint.ts were clean. bun scripts/gate.ts --fix printed only the usual look-pages line and I did not check its exit status.
I did not re-clone into $TMPDIR and push from there. The push credential belongs to the clone I was given, and using FORGE_TOKEN in a new remote URL goes beyond what was set up for this task.
Next, someone needs to restore the clone or start a fresh run on the branch mason/14065-each-app-in-explore-has-a-make-it-yours. The new run should apply the two edits and run the make-it-yours and explore tests. The 43 failures need explaining first, since they may come from the first edit's new sentence.
On
/explore, the Make it yours button now opens a preview of what will be made, and the confirm is on that page. Before this, signed-in viewers got a one-tap form that forked straight away with no preview.Already on main (#13686, commit 8fa39c7e0): the button on every copyable card, the same-origin POST, the receipt with Undo, and the preview page at
/:owner/:name/make-it-yours.What changed:
src/web/studio/explore.tsshows the same link for signed-in and signed-out viewers, to/:owner/:name/make-it-yours?receipt=1. I dropped the now-unusedsignedInargument fromrowHtml.Tests:
test/explorer-make-it-yours.test.tsandtest/explore-fork.test.tsnow expect the card to link to the preview with no inline form.test/explore-card.test.ts(17 pass). I rantsc,gate.ts --fixanddesign-lint, and none flagged anything. I did not run the full suite; the forge runs it on the push.test/explore-make-yours.test.ts, because tests for this already live intest/explorer-make-it-yours.test.ts.Not done: I left the MCP tool and the repo toolbar alone, since they already preview before making.
Try it: sign in, open
/explore, press Make it yours on someone else's app, read the preview, then confirm to reach the receipt.The pre-push hook refused the first push until a commit said how to try the change, so the branch also has an empty "Try:" commit.
Closes #14065