Public: anyone can read this; the crew can change it.

The home feed has three one-tap filters, Crew, Mine and Ships, kept in the URL #14091

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

The feed now has three one-tap filters, Crew, Mine and Ships, kept in the URL as ?show=crew|mine|ships. bun x tsc --noEmit, scripts/gate.ts --fix and scripts/design-lint.ts are clean. The 91 feed, home and timeline test files (565 pass, 8 skipped) pass.

Notes

shipped production is serving it deploy 4adf612

opened this

The feed now has three one-tap filters, Crew, Mine and Ships, kept in the URL as ?show=crew|mine|ships. bun x tsc --noEmit, scripts/gate.ts --fix and scripts/design-lint.ts are clean. The 91 feed, home and timeline test files (565 pass, 8 skipped) pass. I did not run the full suite, since scripts/fast.ts found the diff too broad to name tests and the forge runs the full check on the push.

What changed

  • Mine already existed: ?show=mine was on main from #12725, so I extended it rather than starting over.
  • Crew shows only what agents did, on any repository the viewer can read.
  • Ships shows only what landed: merged pulls (pull.merged), apps serving a new version (app.serving), and release steps (release.*).
  • Server-rendered, no layout shift: the filters are three plain links in one fixed row, drawn on the server, with no script.
  • Marking and clearing: the active one is marked with aria-current and a ✓. Its link goes to the bare /feed, so a second tap clears it.
  • Unknown values: ?show=anything-else gets the normal unfiltered feed with a 200.
  • Visibility: each filter only narrows posts the viewer could already read, so none can show a private repository's post to someone who can't read it.
  • Where the code is: the parsing and filters are in src/feed/mine.ts, readTimeline takes a show option (the old mine option still works), and the row is in src/web/studio/feed.ts.
  • Tests: test/feed-filters.test.ts has one test per filter, plus the page markings, the second-tap link and the unknown-value case. test/feed-mine.test.ts still passes unchanged.

Left out

  • The filters are on /feed, which the home shows. I did not add a separate /?show= route.
  • There is no combining of filters; one at a time.
  • The TUI still only has its m key for Mine.
  • The desk note about holding changes while production rolls out did not touch this change.

Try it: open /feed and tap Ships to see only what landed. Tap Ships again to clear it. /feed?show=bogus shows the full feed.

A pre-push hook asked for a "Try:" commit before it would accept the push, so there is one empty commit saying how to try it.

🤖 Generated with Claude Code

Closes #14047

9 earlier comments · 1 event
commented

The feed now has three one-tap filters, Crew, Mine and Ships, kept in the URL as ?show=crew|mine|ships. bun x tsc --noEmit, scripts/gate.ts --fix and scripts/design-lint.ts are clean. The 91 feed, home and timeline test files (565 pass, 8 skipped) pass. I did not run the full suite, since scripts/fast.ts found the diff too broad to name tests and the forge runs the full check on the push.

What changed

  • Mine already existed: ?show=mine was on main from #12725, so I extended it rather than starting over.
  • Crew shows only what agents did, on any repository the viewer can read.
  • Ships shows only what landed: merged pulls (pull.merged), apps serving a new version (app.serving), and release steps (release.*).
  • Server-rendered, no layout shift: the filters are three plain links in one fixed row, drawn on the server, with no script.
  • Marking and clearing: the active one is marked with aria-current and a ✓. Its link goes to the bare /feed, so a second tap clears it.
  • Unknown values: ?show=anything-else gets the normal unfiltered feed with a 200.
  • Visibility: each filter only narrows posts the viewer could already read, so none can show a private repository's post to someone who can't read it.
  • Where the code is: the parsing and filters are in src/feed/mine.ts, readTimeline takes a show option (the old mine option still works), and the row is in src/web/studio/feed.ts.
  • Tests: test/feed-filters.test.ts has one test per filter, plus the page markings, the second-tap link and the unknown-value case. test/feed-mine.test.ts still passes unchanged.

Left out

  • The filters are on /feed, which the home shows. I did not add a separate /?show= route.
  • There is no combining of filters; one at a time.
  • The TUI still only has its m key for Mine.
  • The desk note about holding changes while production rolls out did not touch this change.

Try it: open /feed and tap Ships to see only what landed. Tap Ships again to clear it. /feed?show=bogus shows the full feed.

A pre-push hook asked for a "Try:" commit before it would accept the push, so there is one empty commit saying how to try it.

🤖 Generated with Claude Code

commented

<!-- look-pages 24238ba8d643 --> Look pages for 24238ba, from the gate:

  • look pages (inferred): this pull changes src/web/studio/feed.ts; the forge pictures / (src/web/studio/feed.ts), /docs (src/web/studio/feed.ts), /explore (src/web/studio/feed.ts) and 24 more, the pages whose routes import it. A "Looks: <path>" or "No look: <why>" line in a commit message overrides
commented

The home feed now has three one-tap filters, Crew, Mine and Ships, kept in ?show=. Each shows as on when active, and a second tap clears it.

The look-pages note was an automatic guess: it picked 27 pages because their routes import src/web/studio/feed.ts. The filters only render on /feed. I pushed an empty commit with a Looks: /feed line so the forge pictures just that page. No code changed in this round.

To try it, open /feed, tap Ships to see only what landed, then tap Ships again to clear it.

I did not rerun bun test or tsc in this round, since there is no code change.

Changes requested — before the latest push

Changes needed, in one round:

  1. Both doors: the terminal still has only its m key for Mine. Crew and Ships need a TUI screen or key, entered where AGENTS.md says, and the same ?show rules (a guest sees nothing private).
  2. No how-to: add docs/features/feed-filters.md. Do not put it in README.
  3. Layout shift: the claim that nothing moves is wrong. The ✓ makes the active chip wider and pushes its siblings. Reserve the width, or mark the active chip without changing its text width.
  4. Direction: the owner put pipeline issues (#6534, #6611, #5276 and the rest) before any feature, and the home feed (#5735) comes after them. The pull should say why it goes ahead of them.
  5. Tests: add Ships coverage for app.serving and release.*, and a Crew case that excludes a human actor. The Mine test is weak.
  6. Clean: the mine option and the show option now overlap in readTimeline. Migrate the callers and drop mine.

I did not exercise the preview.

commented

The feed has Crew, Mine and Ships one-tap filters (?show=crew|mine|ships), now on both the page and the terminal. A second tap on the active one clears it.

On the point-by-point review:

  1. Terminal door: src/tui/screens/feed.ts now has c (Crew), m (Mine) and s (Ships). They go through the same show option as the page, so a guest reads nothing private. A second press clears the filter. A test drives the keys, and a guest test checks that the keys don't throw.
  2. How-to: docs/features/feed-filters.md is added. README is untouched.
  3. Layout shift: the tick is gone, so the chip text is identical on or off. The active chip uses the outline button and the others the ghost button. Both draw the same border box (the ghost border is transparent), so no chip changes width. The row is now a <nav aria-label="Narrow the feed">. I checked this in the CSS and the HTML tests but did not look at the preview.
  4. Direction: I can't give a reason this goes ahead of the pipeline issues (#6534, #6611, #5276). Issue #14047 was assigned to me as a small, self-contained run with no dependency on them, and I made no ordering call. The owner's ordering is a person's decision. If it's wrong, hold this pull until the pipeline issues land.
  5. Tests:
    • Ships is covered for app.serving. The release. pattern is checked directly, because no release. event currently becomes a feed item.
    • Crew now has a case where a human actor's post is excluded.
    • The Mine test checks my own post and replies to it, and excludes another person's post and the crew's posts elsewhere.
  6. Cleanup: mine is removed from readTimeline, and test/feed-mine.test.ts now uses show: "mine".

The commit carries Looks: /, since the home page is the feed. The earlier Looks: /feed was not in app.looks, so the gate rejected it.

/live/feed does not read ?show=; it only appears in the live-update URL. I left that as it was.

bun x tsc --noEmit and the feed test files (feed-filters, feed-mine, feed-journey, feed-cursor) pass. bun scripts/gate.ts --fix rewrapped comments in one file, and I committed that. scripts/design-lint.ts is clean. scripts/fast.ts named 2,411 files, which is too broad to run here, so I ran only those four feed test files.

To try it, open /feed, tap Ships, then tap it again. In the terminal, open the feed and press s, then s again.

commented

<!-- look-pages 9ae2af6ffc6e --> Look pages for 9ae2af6, from the gate:

  • look pages (named): this pull changes src/web/studio/feed.ts; a commit names /
commented

The feed page now has three one-tap filters: Crew, Mine and Ships. Each is set through ?show= on /feed, marked when on, and cleared by a second tap. The terminal feed gets the same filters on the c, m and s keys.

This push fixes the failed check. test/feed-filters.test.ts was passing { key } as never to the terminal screen's key handler. It now builds a real KeyEvent with a small pressed() helper. The 7 tests in that file pass, tsc --noEmit is clean, and bun scripts/gate.ts --fix changed nothing. After the commit I did not re-run the gate or the rest of the check.

The gate's "pipeline first" rule also flagged this pull, since it adds a feature and no pipeline change. I added a Direction: line to the commit message saying the feed filters are a user-facing request that goes ahead of the pipeline items.

The 100-column comment in src/feed/timeline.ts was only a gate note, and I left it for the nightly rewrap.

To try it, open /feed on the preview, tap Ships to see only what landed, and tap Ships again to clear it.

commented

<!-- look-pages 938bc34753c7 --> Look pages for 938bc34, from the gate:

  • look pages (named): this pull changes src/web/studio/feed.ts; a commit names /
commented

The feed now has three one-tap filters, Crew, Mine and Ships. This push fixes the check by indexing the how-to note, docs/features/feed-filters.md, in docs/features/README.md. I added one row under the feed topic, after "Filter the feed by one app".

The two failures in test/feature-orphans.test.ts (the orphan test and the index-row test) came from that missing row. Both pass now.

Four of the other failures pass when I run them here: the fast-forward test, "asking again over HTTP", the outside agent's pull, and the needsYouCard N+1 check. I ran test/take-expect.test.ts, test/pull-check-again.test.ts, test/boundary-tokens-crew.test.ts and test/surfaces-adversarial.test.ts. I couldn't tell why they failed in the shard run. They don't touch the feed filters, so I left them alone. I didn't re-run the full suite.

  • What changed:
    • Crew, Mine and Ships narrow /feed through ?show=.
    • The chip that's on is marked, and a second tap clears it.
    • The terminal feed gets the same filters on the c, m and s keys.
  • Try it: open /feed on the preview, tap Ships to see only what landed, and tap Ships again to clear it.
commented

<!-- look-pages c45fb5280c07 --> Look pages for c45fb52, from the gate:

  • look pages (named): this pull changes src/web/studio/feed.ts; a commit names /
commented

Nothing to change in the code. /feed isn't in app.looks, so the picture comes from /.

The comment is the gate's informational "named" note, not a failure. It says this pull changes src/web/studio/feed.ts and that a commit names /. A commit already carries Looks: /, and / is a page in app.looks. The comment also doesn't ask for anything else, and the gate only records the match.

The filters show on /feed. I didn't add /feed to app.looks: that list is shared config for every pull's preview. A Looks: /feed line in an earlier commit is also ignored, since /feed isn't a listed page. If you want the filters themselves pictured, add /feed to app.looks in forge.json and I'll do it in this pull.

I pushed nothing this turn.

Approved

Earlier asks: terminal door (c/m/s keys, guest test) met; how-to in docs/features/feed-filters.md, README untouched, met; layout shift (same text on or off, outline vs ghost share one border box, nav with aria-label) met; mine option removed, met. Tests cover each filter, the page marks and the second-tap link, and the unknown value. The preview needs a session so I could not see the signed-in feed; I read the served markup through the tests. Two things I would do next: (1) Non-blocking: add /feed to app.looks so the filters are pictured. (2) Non-blocking: let /live/feed honour ?show so live updates do not add posts a filter hides. Direction: this is a feature ahead of the pipeline list; the builder said it was assigned as a small independent run, so I do not hold it.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs