Public: anyone can read this; the crew can change it.

A child forge's proposal carries its own check verdict and tree id, and the parent's pull shows them beside its own check #13676

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

When a child forge proposes a change to its parent, the proposal now carries the child's own check result for that commit and the commit's tree id.

Notes

shipped production is serving it deploy 59903fa

opened this

When a child forge proposes a change to its parent, the proposal now carries the child's own check result for that commit and the commit's tree id. The parent's pull page shows them in one line under "proposed by child": proven on <child>: green at 1a2b3c4d, ending in · tree differs when the pull's head tree isn't the one the child tested. This is information only: nothing that decides whether a pull runs or lands reads it, and the parent's own check still runs as before.

  • Child side (src/actions/upstream.ts): proposeToParentForge looks up the tip's tree and the child's own check result on its default branch. It sends them as attestation: { verdict, tree } on the pull it opens. The result is green, red, pending or none, and a superseded check counts as none. propose_to_parent_forge calls this action, so the MCP tool itself needed no change and the MCP size is unchanged.
  • Boundary (src/core/attestation.ts, src/http/api.ts): only a proposal's pull-open request may carry an attestation. The result must be one of the four words and the tree must be 40 or 64 lowercase hex characters; anything else gets 422 invalid_attestation. The OpenAPI route lists the new field.
  • Storage (src/core/proposal_token.ts, migration 20261115150000): two nullable columns added to pull_proposal. They are read back through the same validation, so a malformed row says nothing. The API, the MCP pull tool and the terminal pick up proposal.attestation automatically.
  • Pull page (src/web/studio/change.ts): the head's tree is only read from git when the pull has an attestation, so other pulls cost nothing extra.

Tests:

  • test/proposal-token.test.ts covers malformed attestations being refused, the matching line with no "tree differs", and a mismatched tree marked tree differs. It also checks the parent's gate still holds that pull. The line doesn't exist without the change, so the test fails without it.
  • test/upstream-forge.test.ts now checks that the parent stores exactly the child's tip tree, with result none because no check ran in that test.
  • The gate, the type check, design lint, test/mcp-size.test.ts and the proposal, upstream, migration, contract and OpenAPI test files all pass. scripts/fast.ts said the diff was too broad to name tests, so I picked those files myself.

Not done here:

  • Anything that admits or lands on the attestation; that is the next step of #13639.
  • Any signature on the attestation: for now it is simply what the child says.
  • The line appears on the conversation tab only, not on the files or conflicts tabs.
  • src/core/pull_trust.ts, named in the issue, is unchanged because no admission rule changes.

The desk hold says production is rolling. I've pushed this branch for a preview only; nothing lands on main until a person merges it.

To try it: on a child forge, land a change and press propose. Then open the new pull on the parent and read the line under "proposed by child".

🤖 Generated with Claude Code

Closes #13645

14 earlier comments · 3 events
commented

When a child forge proposes a change to its parent, the proposal now carries the child's own check result for that commit and the commit's tree id. The parent's pull page shows them in one line under "proposed by child": proven on <child>: green at 1a2b3c4d, ending in · tree differs when the pull's head tree isn't the one the child tested. This is information only: nothing that decides whether a pull runs or lands reads it, and the parent's own check still runs as before.

  • Child side (src/actions/upstream.ts): proposeToParentForge looks up the tip's tree and the child's own check result on its default branch. It sends them as attestation: { verdict, tree } on the pull it opens. The result is green, red, pending or none, and a superseded check counts as none. propose_to_parent_forge calls this action, so the MCP tool itself needed no change and the MCP size is unchanged.
  • Boundary (src/core/attestation.ts, src/http/api.ts): only a proposal's pull-open request may carry an attestation. The result must be one of the four words and the tree must be 40 or 64 lowercase hex characters; anything else gets 422 invalid_attestation. The OpenAPI route lists the new field.
  • Storage (src/core/proposal_token.ts, migration 20261115150000): two nullable columns added to pull_proposal. They are read back through the same validation, so a malformed row says nothing. The API, the MCP pull tool and the terminal pick up proposal.attestation automatically.
  • Pull page (src/web/studio/change.ts): the head's tree is only read from git when the pull has an attestation, so other pulls cost nothing extra.

Tests:

  • test/proposal-token.test.ts covers malformed attestations being refused, the matching line with no "tree differs", and a mismatched tree marked tree differs. It also checks the parent's gate still holds that pull. The line doesn't exist without the change, so the test fails without it.
  • test/upstream-forge.test.ts now checks that the parent stores exactly the child's tip tree, with result none because no check ran in that test.
  • The gate, the type check, design lint, test/mcp-size.test.ts and the proposal, upstream, migration, contract and OpenAPI test files all pass. scripts/fast.ts said the diff was too broad to name tests, so I picked those files myself.

Not done here:

  • Anything that admits or lands on the attestation; that is the next step of #13639.
  • Any signature on the attestation: for now it is simply what the child says.
  • The line appears on the conversation tab only, not on the files or conflicts tabs.
  • src/core/pull_trust.ts, named in the issue, is unchanged because no admission rule changes.

The desk hold says production is rolling. I've pushed this branch for a preview only; nothing lands on main until a person merges it.

To try it: on a child forge, land a change and press propose. Then open the new pull on the parent and read the line under "proposed by child".

🤖 Generated with Claude Code

commented

<!-- look-pages 3e4d041d08d4 --> Look pages for 3e4d041, from the gate:

  • look pages (inferred): this pull changes src/web/studio/change.ts; the forge pictures / (src/web/studio/change.ts), /docs (src/web/studio/change.ts), /explore (src/web/studio/change.ts) and 22 more, the pages whose routes import it. A "Looks: <path>" or "No look: <why>" line in a commit message overrides
commented

When a child forge proposes a change to its parent, it now sends what its own check found on that commit: the verdict (green, red, pending or none) and the commit's tree id. The parent shows this under proposed by child on the pull page as proven on <child>: green at 1a2b3c4d. The line ends · tree differs when the pull's head tree is not the one the child checked. The parent's own check still decides whether the pull lands; nothing reads the child's verdict yet.

  • Sending it: src/actions/upstream.ts takes the child's check state for the tip and the tip's tree.
  • Accepting it: parseAttestation in src/core/attestation.ts checks it in src/http/api.ts. Only a proposal may carry one; it must be a verdict from that set and a 40- or 64-character lowercase hex tree id, and anything else is refused with 422 invalid_attestation.
  • Storing and showing it: it is saved with the proposal (one migration). The API's pull answer returns it under proposal.attestation. The pull page reads the head's tree from git only for a proposal that carries an attestation, so other pulls do no extra work.

What to look at: src/web/studio/change.ts, where changeHead draws the line, and src/core/attestation.ts.

Review feedback (inferred look pages): a commit now says Looks: /preview-admin/sample/pulls/3, the only look page that draws changeHead. The before and after pictures of that page will match, because none of the sample pulls is a child's proposal. The other pages that import change.ts are unchanged.

Gate rules this raised:

  • "both doors": I added docs/features/child-attestation.md and listed it in the features index. The terminal gets no screen, explained in a No door: line: its pull screen does not show proposed by child at all, so there is nothing for this line to sit beside.
  • "pipeline first": the Direction: line says this is step 4 of #13639 (attested admission). The verdict has to arrive and be visible before any admission rule can read it.

Left out: the terminal line, and any gating or ranking on the child's verdict.

Checks run here: bun scripts/gate.ts, bun x tsc --noEmit and bun scripts/design-lint.ts are clean. scripts/fast.ts said the change reaches 2,581 test files, far too many to run, so I picked these and all 78 tests pass: test/proposal-token.test.ts, test/upstream-forge.test.ts, the two both-doors tests, test/ask-admin.test.ts, test/ask-to-reach.test.ts and test/client-forge-doc.test.ts. During the run the sandbox refused connections to maria--forge.test and otto--forge.test; the tests passed anyway.

To try it: on a child forge, land a change on main and press Propose. Then open the pull on the parent and read the line under proposed by child.

🤖 Generated with Claude Code

commented

When a child forge proposes a change to its parent, it now sends what its own check found on that commit: the verdict (green, red, pending or none) and the commit's tree id. The parent shows this under proposed by child on the pull page as proven on <child>: green at 1a2b3c4d. The line ends · tree differs when the pull's head tree is not the one the child checked. The parent's own check still decides whether the pull lands; nothing reads the child's verdict yet.

Nothing new was pushed for the latest check: no check of the head is recorded as failed, and I found no defect in the pull.

  • Sending it: src/actions/upstream.ts takes the child's check state for the tip and the tip's tree.
  • Accepting it: parseAttestation in src/core/attestation.ts checks it in src/http/api.ts. Only a proposal may carry one; it must be a verdict from that set and a 40- or 64-character lowercase hex tree id, and anything else is refused with 422 invalid_attestation.
  • Storing and showing it: it is saved with the proposal (one migration). The API's pull answer returns it under proposal.attestation. The pull page reads the head's tree from git only for a proposal that carries an attestation, so other pulls do no extra work.

What to look at: src/web/studio/change.ts, where changeHead draws the line, and src/core/attestation.ts.

Review feedback (inferred look pages): a commit now says Looks: /preview-admin/sample/pulls/3, the only look page that draws changeHead. The before and after pictures of that page will match, because none of the sample pulls is a child's proposal. The other pages that import change.ts are unchanged.

Gate rules this raised:

  • "both doors": I added docs/features/child-attestation.md and listed it in the features index. The terminal gets no screen, explained in a No door: line: its pull screen does not show proposed by child at all, so there is nothing for this line to sit beside.
  • "pipeline first": the Direction: line says this is step 4 of #13639 (attested admission). The verdict has to arrive and be visible before any admission rule can read it.

Left out: the terminal line, and any gating or ranking on the child's verdict.

Checks run here: bun scripts/gate.ts, bun x tsc --noEmit and bun scripts/design-lint.ts are clean. scripts/fast.ts said the change reaches 2,581 test files, far too many to run, so I picked these and all 78 tests pass: test/proposal-token.test.ts, test/upstream-forge.test.ts, the two both-doors tests, test/ask-admin.test.ts, test/ask-to-reach.test.ts and test/client-forge-doc.test.ts. During the run the sandbox refused connections to maria--forge.test and otto--forge.test; the tests passed anyway.

To try it: on a child forge, land a change on main and press Propose. Then open the pull on the parent and read the line under proposed by child.

🤖 Generated with Claude Code

commented

When a child forge proposes a change to its parent, it now sends what its own check found on that commit: the verdict (green, red, pending or none) and the commit's tree id. The parent shows this under proposed by child on the pull page as proven on <child>: green at 1a2b3c4d. The line ends · tree differs when the pull's head tree is not the one the child checked. The parent's own check still decides whether the pull lands; nothing reads the child's verdict yet.

  • Sending it: src/actions/upstream.ts takes the child's check state for the tip and the tip's tree.
  • Accepting it: parseAttestation in src/core/attestation.ts checks it in src/http/api.ts. Only a proposal may carry one; it must be a verdict from that set and a 40- or 64-character lowercase hex tree id, and anything else is refused with 422 invalid_attestation.
  • Storing and showing it: it is saved with the proposal (one migration). The API's pull answer returns it under proposal.attestation. The pull page reads the proposal once and hands it to changeHead, and reads the head's tree from git only when the proposal carries an attestation.

Fix for the red check: the pull page cost 115 SQL statements against a budget of 114 in test/pages-budget.test.ts. The page read the proposal row twice, once to decide whether to read the head's tree and again inside changeHead. It now reads it once, and the page is back within budget.

What to look at: src/web/studio/change.ts, where changeHead draws the line, and src/core/attestation.ts.

Gate lines in the commits:

  • Look pages: Looks: /preview-admin/sample/pulls/3, the only look page that draws changeHead. Its before and after pictures will match, because none of the sample pulls is a child's proposal.
  • "both doors": docs/features/child-attestation.md is the how-to, listed in the features index. The terminal gets no screen, explained in a No door: line: its pull screen does not show proposed by child at all.
  • "pipeline first": a Direction: line says this is step 4 of #13639 (attested admission). The verdict has to arrive and be visible before any admission rule can read it.

Left out: the terminal line, and any gating or ranking on the child's verdict.

Checks run here: bun scripts/gate.ts, bun x tsc --noEmit and bun scripts/design-lint.ts are clean. The change reaches too many tests to run them all, so I ran test/pages-budget.test.ts, test/proposal-token.test.ts and test/upstream-forge.test.ts, and all pass.

To try it: on a child forge, land a change on main and press Propose. Then open the pull on the parent and read the line under proposed by child.

🤖 Generated with Claude Code

Changes requested — before the latest push

The change does what the issue asks on the page, and the boundary validation is sound: a fixed verdict set, a hex tree id, 422 on anything else, proposals only, and the page output is escaped. Three things to fix in one round.

  1. Both doors: the terminal does not show the line. The brief says what a person can do on the page they can do in the terminal. The docs concede the gap ('Not yet'), which is a miss on a strict list. Add the attestation line to the terminal's pull screen under src/tui/, or show 'proposed by child' and the line there together.
  2. Tests: the child side only proves verdict 'none'. Nothing fails if verdictOfCheck maps ok, failed or pending wrongly, or if the child sends the wrong tip's verdict. Add a test for the mapping (ok to green, failed to red, pending to pending, anything else to none) and one where the child's check is green and the parent receives green.
  3. Clean: remove the unused data-attested attribute, and replace the optional head parameter of changeHead (which has two code paths) with one path. See the comments.

Box 3 needs no change. Box 4 is met by the proposal-token test.

commented

When a child forge proposes a change to its parent, it now also sends its own check's verdict on that commit and the commit's tree id. The parent shows proven on <child>: <verdict> at <tree8> after proposed by child. This shows on the pull's change tab, its files tab, its conflicts page and the terminal's pull screen. The line ends · tree differs when the pull's head is no longer the tree the child checked. It is information only: nothing is gated or ranked on it, and the parent's own check still decides whether a pull lands.

This round's review fixes:

  • Both doors: the terminal's pull screen already said proposed by child. It now adds the attestation line right after it. The docs' "Not yet" paragraph was wrong and is replaced.
  • One code path: changeHead's last parameter is now required. Every caller passes the proposal, read by the new pullProposalAt in src/core/proposal_token.ts, which reads the head's tree only when the child sent an attestation. Other pulls cost no extra git read. The terminal's local source (src/view/local.ts) uses the same reader, and PullFacts.proposal now carries the attestation and the head's tree.
  • Markup: data-attested and the second proposed-by span are gone. The line now sits inside the existing span.
  • Tests:

- test/attestation.test.ts is new. It checks the mapping (ok → green, failed → red, pending → pending, anything else such as superseded → none), the input rules and the wording of the line. - test/upstream-forge.test.ts adds a case where the child's check of its tip passed and the parent stores green. A failed check on another commit is present to show it isn't the one sent. - test/proposal-token.test.ts now also checks the files tab and the terminal screen. - test/number-retired.test.ts changed only to pass the new required arguments to changeHead; the test itself was right.

Checks: bun scripts/gate.ts --fix, bun scripts/design-lint.ts and bun x tsc --noEmit pass. scripts/fast.ts selected 2,630 test files, too many to run here. Instead I ran 21 files covering the pull pages, conflicts, the terminal pull screen, proposals and upstream: 105 pass, 0 fail.

To try it: on a child forge, land a change and press Propose. On the parent, open the pull on either tab, or in the terminal, and read the line after proposed by child.

🤖 Generated with Claude Code

commented

<!-- look-pages 8c7d0ef22693 --> Look pages for 8c7d0ef, from the gate:

  • look pages (named): this pull changes src/web/pages/conflicts.ts, src/web/pages/pull.ts, src/web/studio/change.ts; a commit names /preview-admin/sample/pulls/3
commented

A child forge's proposal now carries its own check verdict and the tree id of the commit it proposes. The parent's pull shows them beside its own check as one line, proven on <child>: <verdict> at <tree>, with · tree differs when the pull's head is not the tree the child checked. The line is information only: the parent's gate still runs on the pull and nothing passes because of it.

  • Input: src/core/attestation.ts reads the attestation at the API boundary. It accepts a verdict from a fixed set (green, red, pending, none) and a hex tree id, and refuses anything else. src/actions/upstream.ts sends the child's own check state.
  • Storage: two nullable columns on pull_proposal, added by migration 20261115150000-pull-proposal-attestation. Rows are read back through the same parser, so a bad row shows nothing.
  • One read: pullProposalAt reads the proposal and the head's tree once. The pull page, the Files tab, the conflicts page, the change head and the terminal's pull screen all use it. It only touches git when a child actually attested.

The look-pages note on 8c7d0ef: the commit named /preview-admin/sample/pulls/3, but the preview's sample pull had no proposal, so that picture could never show the line. src/spawn/preview-seed.ts now records the sample pull as proposed by child kid, with a green verdict on the head's real tree, so the look shows the line without tree differs. test/pull-phone-fit.test.ts checks the seeded page draws it.

Left out on purpose: the attestation never gates or lands anything, and the terminal shows the line but has no action for it (the how-to in docs/features/child-attestation.md says why).

To try it, open the preview's /preview-admin/sample/pulls/3 and look at the line beside the check. For a real child, send {"attestation": {"verdict": "green", "tree": "<40 or 64 hex>"}} with a proposal, or let the child's upstream action send it.

bun x tsc --noEmit, scripts/gate.ts --fix and scripts/design-lint.ts pass. scripts/fast.ts reported the change as too broad to name its tests (2,630 files), so I ran the ones that cover it, and they pass: test/pull-phone-fit.test.ts, test/looks-owner.test.ts, test/flows-lines.test.ts, test/preview-looks.test.ts, plus the attestation, proposal-token and upstream tests from the earlier commits. The Chromium phone measurements were skipped because no Chromium starts in this sandbox.

🤖 Generated with Claude Code

Approved — before the latest push

Earlier asks are met: the terminal pull screen, the files and conflicts tabs and the page head all read the proposal through pullProposalAt. changeHead now takes the proposal as a required argument. The how-to is in docs/features/child-attestation.md, not README. The preview seed now records a kid proposal, so the look shows the line, and pull-phone-fit tests it. The input is validated at the boundary, only a proposal may carry an attestation, the output is escaped, and nothing gates on the verdict. The migration is additive and pinned. I could not diff against 705dfd1c8228 because the clone lacks that commit, so I read the change as listed. Non-blocking: the seed code in src/spawn/preview-seed.ts is only for previews.

commented

<!-- look-pages 1d4b076d85b9 --> Look pages for 1d4b076, from the gate:

  • look pages (named): this pull changes src/web/pages/conflicts.ts, src/web/pages/pull.ts, src/web/studio/change.ts; a commit names /preview-admin/sample/pulls/3
commented

A child forge's proposal now carries its own check verdict and the tree id of the commit it proposes. The parent's pull shows them beside its own check as one line, proven on <child>: <verdict> at <tree>, with · tree differs when the pull's head is not the tree the child checked. The line is information only: the parent's gate still runs on the pull and nothing passes because of it.

  • Input: src/core/attestation.ts reads the attestation at the API boundary. It accepts a verdict from a fixed set (green, red, pending, none) and a hex tree id, and refuses anything else. src/actions/upstream.ts sends the child's own check state.
  • Storage: two nullable columns on pull_proposal, added by migration 20261115150000-pull-proposal-attestation. Rows are read back through the same parser, so a bad row shows nothing.
  • One read: pullProposalAt reads the proposal and the head's tree once. The pull page, the Files tab, the conflicts page, the change head and the terminal's pull screen all use it. It only touches git when a child actually attested.
  • Preview: the seeded sample pull (/preview-admin/sample/pulls/3, the page the commits name in their Looks: line) is recorded as proposed by child kid, with a green verdict on the head's real tree. Its look shows the line without tree differs.

The gate's "small and single-purpose" rule failed the previous push at 21 files. The test for the seeded attestation now sits in test/attestation.test.ts, which the pull already changes, instead of test/pull-phone-fit.test.ts. That brings the pull to 20 files, and bun scripts/gate.ts now passes. The test fails when the seed's proposal row is removed.

Left out on purpose: the attestation never gates or lands anything, and the terminal shows the line but has no action for it (the how-to in docs/features/child-attestation.md says why).

To try it, open the preview's /preview-admin/sample/pulls/3 and look at the line beside the check. For a real child, send {"attestation": {"verdict": "green", "tree": "<40 or 64 hex>"}} with a proposal, or let the child's upstream action send it.

bun x tsc --noEmit and bun scripts/gate.ts pass. These tests pass: test/attestation.test.ts, test/proposal-token.test.ts, test/upstream-forge.test.ts, test/number-retired.test.ts, test/looks-owner.test.ts, test/preview-looks.test.ts, test/flows-lines.test.ts and test/pull-phone-fit.test.ts. The Chromium phone measurements in that last one were skipped because no Chromium starts in this sandbox.

🤖 Generated with Claude Code

commented

<!-- look-pages 120afa2aab53 --> Look pages for 120afa2, from the gate:

  • look pages (named): this pull changes src/web/pages/conflicts.ts, src/web/pages/pull.ts, src/web/studio/change.ts; a commit names /preview-admin/sample/pulls/3
commented

A child forge's proposal now carries the verdict of its own check on that commit and the commit's tree id. The parent's pull shows both next to its own check as one line, proven on <child>: <verdict> at <tree>. The line ends with · tree differs when the pull's head is no longer the tree the child checked. The line is information only: the parent's check still decides whether the pull lands.

  • Input: src/core/attestation.ts reads the attestation where the API takes the proposal. It accepts only a verdict from a fixed set (green, red, pending, none) and a hex tree id, and refuses anything else with 422 invalid_attestation. src/actions/upstream.ts sends the child's own check state.
  • Storage: migration 20261115150000-pull-proposal-attestation adds two nullable columns to pull_proposal. Rows are read back through the same parser, so a bad row shows no line.
  • One read: pullProposalAt reads the proposal and the head's tree once. The pull page, the Files tab, the conflicts page, the change head and the terminal's pull screen all use it. It only reads git when a child actually sent an attestation.
  • Preview: the sample pull at /preview-admin/sample/pulls/3 is recorded as proposed by child kid, with a green verdict on the head's real tree. That page is the one the commits name in their Looks: line.

About the look-pages note on 120afa2: the gate correctly named /preview-admin/sample/pulls/3, but that page on this pull's preview did not show the line. The preview's data was seeded before the seed change, and the step that sets up the sample data only runs on a preview's first boot. Recording the attestation now happens in its own step, seedAttestedPull, which runs on every boot like the other catch-up steps. It adds the row only when the pull has no attestation yet. test/attestation.test.ts now deletes the row, seeds again, and checks that the attestation comes back.

Checks: the gate, the type check and the attestation, pages-budget and preview tests pass here. test/pull-phone-fit.test.ts is skipped because the sandbox has no Chromium, so the phone layout of the pull page was not measured.

🤖 Generated with Claude Code

Approved — before the latest push

Since my last review the only change is seedAttestedPull in src/spawn/preview-seed.ts, which runs on every preview boot, and its test. It writes one row and no child exists. It is idempotent, and the preview path is the only caller. The preview at /preview-admin/sample/pulls/3 now shows proven on kid: green at a4abaf08 with no tree differs. The earlier asks (terminal door, one read path, docs outside the README, tests) were met in earlier rounds. Non-blocking: recordPullProposal in the seed uses a fake origin https://kid.example; that is fine for a preview but keep it out of any production seed.

commented

A child forge's proposal now carries the verdict of its own check on that commit and the commit's tree id. The parent's pull shows both next to its own check as one line, proven on <child>: <verdict> at <tree>. The line ends with · tree differs when the pull's head is no longer the tree the child checked. The line is information only: the parent's check still decides whether the pull lands.

  • Input: src/core/attestation.ts reads the attestation where the API takes the proposal. It accepts only a verdict from a fixed set (green, red, pending, none) and a hex tree id, and refuses anything else with 422 invalid_attestation. src/actions/upstream.ts sends the child's own check state.
  • Storage: migration 20261115150000-pull-proposal-attestation adds two nullable columns to pull_proposal. Rows are read back through the same parser, so a bad row shows no line.
  • One read: pullProposalAt reads the proposal and the head's tree once. The pull page, the Files tab, the conflicts page, the change head and the terminal's pull screen all use it. It only reads git when a child actually sent an attestation.
  • Preview: seedAttestedPull runs on every boot. It records the sample pull at /preview-admin/sample/pulls/3 as proposed by child kid, with a green verdict on the head's real tree, so a preview seeded before this change shows the line too.

Merge with main: the two conflicts were additions on both sides, and both are kept:

  • src/core/proposal_token.ts keeps main's revokeProposalTokens.
  • src/http/api.ts keeps both imports, parseAttestation and listAppReleases.

scripts/gate.ts --fix rewrapped comments in 15 files that came from main. I did not commit those, because they would add unrelated files to this pull and take it past its 20-file limit. The pull still touches 20 files.

Checks: the type check passes. The attestation, proposal-token, upstream-forge, pages-budget, OpenAPI and MCP-size tests pass (605 tests).

🤖 Generated with Claude Code

commented

<!-- look-pages 1018c2cd0b0b --> Look pages for 1018c2c, from the gate:

  • look pages (named): this pull changes src/web/pages/conflicts.ts, src/web/pages/pull.ts, src/web/studio/change.ts; a commit names /preview-admin/sample/pulls/3
commented

A child forge's proposal now carries the verdict of its own check on that commit and the commit's tree id. The parent's pull shows both next to its own check as one line, proven on <child>: <verdict> at <tree>. The line ends with · tree differs when the pull's head is no longer the tree the child checked. The line is information only: the parent's check still decides whether the pull lands.

  • Input: src/core/attestation.ts reads the attestation where the API takes the proposal. It accepts only a verdict from a fixed set (green, red, pending, none) and a hex tree id, and refuses anything else with 422 invalid_attestation. src/actions/upstream.ts sends the child's own check state.
  • Storage: migration 20261115150000-pull-proposal-attestation adds two nullable columns to pull_proposal. Rows are read back through the same parser, so a bad row shows no line.
  • One read: pullProposalAt reads the proposal and the head's tree once. The pull page, the Files tab, the conflicts page, the change head and the terminal's pull screen all use it. It only reads git when a child actually sent an attestation.
  • Preview: seedAttestedPull runs on every boot. It records the sample pull as proposed by child kid, with a green verdict on the head's real tree.

Look-pages note on 1018c2c: the gate named /preview-admin/sample/pulls/3, the page the commits' Looks: line asks for. That page on this pull's preview answers 200 and shows proven on kid: green at a4abaf08, with no tree differs, so its picture shows the change. Nothing needed fixing, so nothing new is pushed for this note.

Review: read changeHead in src/web/studio/change.ts first, then src/core/attestation.ts.

🤖 Generated with Claude Code

Approved

Approved. I could not diff against 9fcf8817a24b (the commit is not in the clone), so I read the whole change. The attestation is validated at the boundary (a fixed verdict set and a 40- or 64-character lowercase hex tree id, 422 invalid_attestation otherwise), accepted only on a proposal, and read back through the same parser. The line renders through the escaped html template, and the head tree is read from git only when a child attested. Nothing gates on it. The terminal shows the line, the how-to is in docs/features, README is untouched, and tests cover the mapping, the boundary, tree differs on both tabs and in the terminal, the child sending its own verdict, and the seed. The preview shows proven on kid: green at a4abaf08 on /preview-admin/sample/pulls/3. Non-blocking: the preview seed writes a fake kid proposal row on every preview boot, which is acceptable only because it runs in previews.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs