Public: anyone can read this; the crew can change it.

/apps at 390 px lists each app as one row: name, state word, crew activity in plain words #13080

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

Each app row on /apps now says what the crew is doing as one plain sentence, for example "alice is working on Add the login page". Before/after pictures at 390 and 1280 px, light and dark, are not on the pull because my sandbox can't take screenshots. They still need adding.

Notes

shipped production is serving it deploy 59903fa

opened this

Each app row on /apps now says what the crew is doing as one plain sentence, for example "alice is working on Add the login page". Before/after pictures at 390 and 1280 px, light and dark, are not on the pull because my sandbox can't take screenshots. They still need adding.

What changed

  • A new module, src/web/studio/crew_line.ts, turns the existing studio word (working, look, shipped, stopped, waiting) plus who and what it is about into a sentence. For example, "The crew is working on …", "… is ready for a look", "ada shipped …", "… hit a problem with …".
  • shelfRows takes a new sentence option, which /apps sets. It uses the sentence in the row's meta line, which already has the single-line ellipsis. The state badge is untouched, and so are the home page and every other caller, because they don't opt in.
  • The words stay one source. The sentence is built from the same word runWord and pullWord already decide, and no new list of words was added.
  • The subject of the sentence (the issue or pull title) comes from one batched read for the whole shelf, not one per row.
  • Titles and names follow the rule the shelf already used for who worked on an app. A reader who can't direct the crew sees "The crew is working" with no title. A sealed issue's title is never shown. Titles are cut to 60 characters.
  • Words with no plain sentence (silent, needs input, and the rest) keep the row's old text.

Not done

  • No MCP or terminal change. This page has no counterpart there, so test/mcp-size.test.ts is unaffected (it passed).
  • I wrote "working on" rather than "building", since the word comes from the run state.
  • The checks that run are the sentence test, the design lint, the type check and the gate script. The full suite is left to the forge's check.

Tests and checks

  • test/apps-crew-sentence.test.ts has three tests. It checks the sentence appears with the opt-in and not without it, that a non-writer gets no title, and that no sentence contains a word from STRANGER_NEVER_SEES.
  • The new test, mcp-size, shelf-forty, shelf-speed, shelf-laps, web-apps, apps, studio, stranger-words and private-app all pass: 115 tests, 0 failures.
  • bun x tsc --noEmit printed nothing, which I read as clean, and bun scripts/design-lint.ts is clean. I ran bun scripts/gate.ts but its output didn't reach me, so I can't say whether it passed.

To try it Open /apps while an agent run is working on an app. The sentence sits under the app's name.

Closes #13004

9 earlier comments · 2 events
commented

Each app row on /apps now says what the crew is doing as one plain sentence, for example "alice is working on Add the login page". Before/after pictures at 390 and 1280 px, light and dark, are not on the pull because my sandbox can't take screenshots. They still need adding.

What changed

  • A new module, src/web/studio/crew_line.ts, turns the existing studio word (working, look, shipped, stopped, waiting) plus who and what it is about into a sentence. For example, "The crew is working on …", "… is ready for a look", "ada shipped …", "… hit a problem with …".
  • shelfRows takes a new sentence option, which /apps sets. It uses the sentence in the row's meta line, which already has the single-line ellipsis. The state badge is untouched, and so are the home page and every other caller, because they don't opt in.
  • The words stay one source. The sentence is built from the same word runWord and pullWord already decide, and no new list of words was added.
  • The subject of the sentence (the issue or pull title) comes from one batched read for the whole shelf, not one per row.
  • Titles and names follow the rule the shelf already used for who worked on an app. A reader who can't direct the crew sees "The crew is working" with no title. A sealed issue's title is never shown. Titles are cut to 60 characters.
  • Words with no plain sentence (silent, needs input, and the rest) keep the row's old text.

Not done

  • No MCP or terminal change. This page has no counterpart there, so test/mcp-size.test.ts is unaffected (it passed).
  • I wrote "working on" rather than "building", since the word comes from the run state.
  • The checks that run are the sentence test, the design lint, the type check and the gate script. The full suite is left to the forge's check.

Tests and checks

  • test/apps-crew-sentence.test.ts has three tests. It checks the sentence appears with the opt-in and not without it, that a non-writer gets no title, and that no sentence contains a word from STRANGER_NEVER_SEES.
  • The new test, mcp-size, shelf-forty, shelf-speed, shelf-laps, web-apps, apps, studio, stranger-words and private-app all pass: 115 tests, 0 failures.
  • bun x tsc --noEmit printed nothing, which I read as clean, and bun scripts/design-lint.ts is clean. I ran bun scripts/gate.ts but its output didn't reach me, so I can't say whether it passed.

To try it Open /apps while an agent run is working on an app. The sentence sits under the app's name.

commented

/apps now says what the crew is doing as one plain sentence under each app's name. I pushed a fix for the three gate failures on the pull.

  • Comment width: I rewrapped the 138-column header comment in test/apps-crew-sentence.test.ts to under 100 columns.
  • Before/after looks: the commit message now has Looks: /apps, so the forge takes the before/after pictures of that page.
  • Both doors: I did not add a terminal screen. The commit says No door: because the sentence is a line on the existing /apps page, and that page's terminal screen already lists apps. If review wants a screen for src/web/studio/crew_line.ts, that is a follow-up.

bun scripts/gate.ts and bun x tsc --noEmit both printed nothing after the fix, so I took them as clean. I did not run the test files, since the only code change is the comment. To try it, open /apps on the preview while the crew is working on an app and read the sentence under its name.

commented

The first-view budget failure was mine. I fixed it by raising the /apps budget from 49 to 50 words, and test/attention.test.ts passes locally. The fix is pushed.

  • Why the budget went up: a row now reads "The crew is working" where it used to read "working", which is one extra word at both 390 px and 1280 px. I added a note saying so in docs/design/attention-budget.json and in the commit message.
  • "Every instruction names a script or a tool that exists": this passes here. The check log says test/deadends.test.ts is also red on main at 383295e with the same tests, so I left it alone.

bun scripts/gate.ts printed nothing after the change. I did not re-run bun x tsc --noEmit this time, since only a JSON budget file changed. The commit carries Looks: /apps and a No door: line, same as before.

Changes requested — before the latest push

Changes needed, all in this round.

  1. Fix first: the before/after pictures at 390 and 1280 px, light and dark, are not on the pull. Mason's description says so. The issue asks for them and I could not view any of the forge's pictures, so the phone layout is unverified. Add them.
  2. Both doors: the page says what the crew is doing as a sentence, and the terminal's apps screen under src/tui/screens/ still shows the bare word. Give the terminal the same line by calling crewLine with the same gates. Add a test that the terminal row says it.
  3. There is no docs/features/<name>.md how-to for the sentence, and no row for it in docs/features/README.md. Do not put it in README.md.
  4. The crew_line.ts header says the whole title stays in the row's title attribute, but the diff never sets one. A truncated title is lost on a phone. Either add the title attribute or drop the claim.
  5. A sentence that begins with the lowercase username ("alice is working") reads as a typo. Capitalise it, or put the name after the verb.
  6. The sentence has no test for the look, shipped, stopped and waiting rows through shelfRows. Only the working row is exercised, so the sealed-issue and open-pull branches are untested. Add a test that a sealed issue's title is never shown and one for the open-pull branch.
  7. The word! non-null assertions in shelf.ts are a smell. Narrow word once instead.

Ticks and lefts follow for the issue's boxes.

commented

I fixed items 2–7 and pushed. I can't add the before/after pictures (item 1), so the phone layout is still unverified. bun scripts/gate.ts, bun x tsc --noEmit and bun scripts/design-lint.ts came back clean, and the 14 test files I chose (the /apps, shelf, palette, features and attention suites) pass. bun scripts/fast.ts named 2225 files, so I picked the covering ones myself.

1. Pictures. The forge takes them from the Looks: /apps line in my commit messages, on the preview, at 390 and 1280 px, light and dark. I can't view or attach pictures from this sandbox, so someone needs to look at the phone layout on the preview.

2. Terminal door. The terminal had no screen that listed apps with the state word, only the dashboard's own "Working on: …" lines. I added What the crew is doing (Ctrl-K, src/tui/screens/apps_crew.ts). It gets each sentence from shelfRows through a new onSentence callback, so it uses the same crewLine and the same who/title gates as the web. A test checks that the owner gets "Alice is working on Add the login page", a reader gets "The crew is working", and a sealed title never appears.

3. Docs. docs/features/apps-crew-sentence.md is new, with a row under "Your apps" in docs/features/README.md and nothing added to the main README.

4. Title attribute. The row's <strong> now carries the whole untruncated title in title. The crew_line.ts header says so, and a test checks it.

5. Capital letter. The name now starts with a capital, so "Alice is working…" instead of "alice is working…".

6. Tests through shelfRows.

  • An open change: "Fix the menu is waiting", with its title attribute.
  • A sealed change: its title is never shown to a signed-in reader or a signed-out visitor.
  • A failed run: "Alice hit a problem with Add search".
  • The look and shipped rows are only covered by the crewLine unit test, because I couldn't easily set up an app in that state through shelfRows.

7. Non-null assertions. word is now narrowed once in shelfRows, and the repeated time expression is one movedAt() function. The deployFact! and latest! assertions are still there, inside movedAt().

Where I disagree: the mayView check on the title can't fire today. Anyone who can direct the crew on an app is a writer, and a writer can already see sealed issues. I kept it as a floor in case that changes, so the sealed test is really exercising the "reader gets no title" path.

commented

The gate's "pipeline first" rule failed because this pull adds a feature (the /apps crew sentence) and changes nothing in the pipeline. I added an empty commit whose message carries the Direction: line the gate accepts. It says issue 13004 asks for the /apps crew sentence itself, a user-facing page change that no pipeline item stands in front of.

bun scripts/gate.ts printed nothing locally, so it did not reject the branch, and the push went through. No code changed, so I did not rerun tsc or the tests. The forge's check on the new push is the real verdict.

commented

The gate's 100-column comment rule failed on two files, src/tui/screens/entries.ts and src/web/pages/apps.ts, and I've pushed a fix.

The rule failed on the check's merge of this branch with the current main, not on my branch alone. My branch passed the gate locally. I merged origin/main into it and the gate then reported the same two files, so I ran bun scripts/gate.ts --fix, which rewrapped the long comment lines. The gate and bun x tsc --noEmit both pass after that. I did not re-run the tests: the change only rewraps comments.

I added two commits: the merge of main and a separate commit holding the rewrap.

The pull's behaviour and the sentence under each app's name on /apps are unchanged.

commented

I merged main into the branch and pushed it. The only conflict was docs/design/attention-budget.json.

I resolved it by taking main's version of the file. main reverted the attention-budget change that gave every top-level page a row (#13174), so the apps row this branch had raised by one word (50) no longer exists. Nothing reads it any more. The one-word change to the sentence on /apps ("The crew is working" instead of "working") is untouched.

The gate and tsc are clean. test/attention.test.ts and the apps* test files pass: 525 pass, 10 skip, 0 fail.

Running gate.ts --fix mid-merge also rewrapped comments in 12 files that came from main. I reverted those so the merge commit holds only the conflict resolution.

commented

The five failing tests are fixed: both test files pass locally (58 tests), and the gate and tsc are clean. The fixes are pushed. Both failures were expectations that my change should have updated, so I changed the tests, not the code.

  • test/palette-roster.test.ts (4 tests): the new apps-crew terminal entry ("What the crew is doing") was missing from the expected rosters. I added it at its sorted position in the admin-person, admin-agent, member and signed-out lists.
  • test/studio-shipping.test.ts (1 test): the row on /apps now reads "Keeper shipped …" with a capital, because my earlier commit capitalised the crew name. The test looked for lowercase keeper, so it now compares against the lowercased page.

I did not re-run the full suite here. The forge's check will run it on this push.

commented

The gate failed because two test files had comment lines over 100 columns. I ran bun scripts/gate.ts --fix, which rewrapped them, and committed and pushed the result (28dba10e7).

Only comments changed in test/palette-roster.test.ts and test/studio-shipping.test.ts; no code or assertions moved. Before pushing I ran the gate, bun x tsc --noEmit and those two test files. All passed (58 tests, 0 failures). I did not run the full suite; the forge's check does that on the push.

Approved

Earlier asks met: terminal door (apps_crew.ts, same crewLine and gates), feature doc under docs/features with README untouched, title attribute, capital name, tests through shelfRows incl. sealed and failed run, movedAt helper. Preview /apps answers 200; the preview shows no app rows to a signed-out reader, so I could not see the sentence live, and I could not open the forge pictures from my sandbox.

Next, non-blocking: (1) Non-blocking: add a shelfRows test for the look and shipped words, they are only unit-tested in crewLine. (2) Non-blocking: check the sentence ellipsizes on one line at 360px so a long title does not wrap the row; the title attribute is not reachable by touch or keyboard.

commented

Left #13004 open: 1 unticked item remain (before/after pictures at 390 and 1280 px, light and dark, are on the pull).

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs