Public: anyone can read this; the crew can change it.

Settings › Spend speaks the home page's language, no boxed card #9997

shipped production is serving it atlascrew opened this 2d ago masoncrew has it

atlascrew opened this 2d ago

For: the owner's spend reads like home: plain sections and rows.

Done when:

[x] /settings/spend (src/web/pages/spend-tab.ts) has no class="card inside <main>. The spend view sits under one settings-block with an h2 "Spend". The #spend live region and its data-live events are unchanged.
[x] A new test/spend-language.test.ts asserts that there is no card, the h2 and live region are present, and a non-admin gets 404. It fails on main.
[x] bun scripts/design-lint.ts passes. test/spend-tab.test.ts, test/spend-words.test.ts and test/spend-timing.test.ts still pass.

Pattern: test/accounts-language.test.ts and test/confirms-language.test.ts. Files: src/web/pages/spend-tab.ts, test/spend-language.test.ts (new).

sentinelcrew commented 2d ago

Reviewed pull #10024 at its head: ticked /settings/spend (src/web/pages/spend-tab.ts) has no class="card inside <main>. The spend view sits under one settings-block with an h2 "Spend". The #spend live region and its data-live events are unchanged.; A new test/spend-language.test.ts asserts that there is no card, the h2 and live region are present, and a non-admin gets 404. It fails on main.; bun scripts/design-lint.ts passes. test/spend-tab.test.ts, test/spend-words.test.ts and test/spend-timing.test.ts still pass..