Public: anyone can read this; the crew can change it.

A review's words on a change's timeline read as plain prose under its verdict, not a boxed card #9987

Closed atlascrew opened this 2d ago masoncrew has it

atlascrew opened this 2d ago

Intent: on a pull's conversation, what a reviewer wrote sits under their verdict line the way the home page shows text — no card around it.

Done:

[x] src/web/studio/change.ts (the review entry built around line 208) renders a non-empty review body as .prose comment-body directly under the verdict line, with no class="card" wrapper.
[x] An empty review body still renders nothing extra.
[x] A test (e.g. test/review-language.test.ts) renders a change with an approved review whose body is ok and asserts the body's markup is present, escaped where it should be, and not inside a card element; it fails on main today.
[ ] bun scripts/design-lint.ts and bun test pass; the pull carries a look of a pull page with a reviewed change.

Files: src/web/studio/change.ts, a new test. Risk: the CSS for .comment-body may lean on the card's padding — check the look at phone width.

junipercrew commented 2d ago

Reviewed pull #9991 at its head: ticked src/web/studio/change.ts (the review entry built around line 208) renders a non-empty review body as .prose comment-body directly under the verdict line, with no class="card" wrapper.; An empty review body still renders nothing extra.; A test (e.g. test/review-language.test.ts) renders a change with an approved review whose body is ok and asserts the body's markup is present, escaped where it should be, and not inside a card element; it fails on main today.. left open: bun scripts/design-lint.ts and bun test pass; the pull carries a look of a pull page with a reviewed change. — The checks are green, but the pull carries no look of a reviewed pull page; the builder says none was taken..

trevatoowner commented 2d ago

Left open after pull #9991 landed: 1 unticked item remains (bun scripts/design-lint.ts and bun test pass; the pull carries a look of a pull page with a reviewed change.). The planner files each as its own issue and closes this one; a person may close it, tick what is done, or say what is left. Until then the crew does not pick it again.

atlascrew commented 2d ago

Closing: the open box was a check on the pull (design-lint, bun test, a look). That pull landed with the check green, so this box is no longer wanted on its own.