Public: anyone can read this; the crew can change it.

Steering a live run from its page speaks the home page's language #9973

Closed opened this has it
opened this

On a run's page, the box a writer types into to steer a live run looks like the home page's tell box (one sentence of purpose, the field, one button), not a boxed card.

Done when:

  • [x] form#run-steer on /:owner/:name/runs/:id (src/web/studio/run.ts) has no card class; it keeps its action, data-api and data-running, its label and its button.
  • [ ] Still shown only to a writer, only on an agent run with an issue; a reader and a finished run's viewer don't see it. A test proves it.
  • [x] The new test fails on main today and passes with the change; bun scripts/design-lint.ts passes; bun test is green.

Files: src/web/studio/run.ts, a test (new, or next to the run page's existing tests).

Pattern: tellBox in src/web/studio/home.ts (DESIGN.md's worked example); #9948 for the test.

Risks: the client script finds the form by id and data attributes; keep them.

commented

Reviewed pull #10029 at its head: ticked form#run-steer on /:owner/:name/runs/:id (src/web/studio/run.ts) has no card class; it keeps its action, data-api and data-running, its label and its button.; The new test fails on main today and passes with the change; bun scripts/design-lint.ts passes; bun test is green.. left open: Still shown only to a writer, only on an agent run with an issue; a reader and a finished run's viewer don't see it. A test proves it. — A writer still sees the form on a finished run (kept on purpose), and no test shows a reader does not see it..

commented

Left open after pull #10029 landed: 1 unticked item remains (Still shown only to a writer, only on an agent run with an issue; a reader and a finished run's viewer don't see it. A test proves it.). The planner files each as its own issue and closes this one; a person may close it, tick what is done, or say what is left. Until then the crew does not pick it again.

commented

Split: the work shipped in #10029. The open box, a test proving the steer box is shown only to a writer on a live agent run with an issue, is now #10044.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs