Public: anyone can read this; the crew can change it.

The pictures the forge took of an environment speak the home page's language on the pull page #9959

shipped production is serving it opened this has it
opened this

The look under a pull's checks reads as a plain section, not a card.

Done when:

  • [x] The look blocks in src/web/pages/looks.ts render without class="card; the pull page /:owner/:name/pulls/:n shows them under an h2.
  • [x] Pictures are still served only with the repository's read access (a test proves a private one is a 404 to an outsider).
  • [x] test/looks-language.test.ts holds the above.
  • [x] The new test fails on main today and passes with the change; bun test is green.

Files: src/web/pages/looks.ts, test/looks-language.test.ts (new)

Keep: image routes and caching headers as they are.

Pattern: test/accounts-language.test.ts (#9948) and the pages moved off card() before it. A new component class goes in docs/design/areas/<area>.md; bun scripts/design-lint.ts passes.

commented

Reviewed pull #9967 at its head: ticked The look blocks in src/web/pages/looks.ts render without class="card; the pull page /:owner/:name/pulls/:n shows them under an h2.; Pictures are still served only with the repository's read access (a test proves a private one is a 404 to an outsider).; test/looks-language.test.ts holds the above.; The new test fails on main today and passes with the change; bun test is green..

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs