Public: anyone can read this; the crew can change it.

The Held files list on /boards speaks the home page's language #9956

shipped production is serving it opened this has it
opened this

Files an admin has held read as plain rows under a heading, not a card.

Done when:

  • [x] boardsHoldsCard (src/web/pages/boards-holds.ts) renders a section with an h2 and a .list, no class="card.
  • [x] It still reads in one statement scoped by adminRepoIds; a private repository's hold never shows to a non-admin (a test proves it).
  • [x] test/boards-holds-language.test.ts holds the above.
  • [x] The new test fails on main today and passes with the change; bun test is green.

Files: src/web/pages/boards-holds.ts, test/boards-holds-language.test.ts (new)

Keep: the release action and its same-origin POST.

Pattern: test/accounts-language.test.ts (#9948) and the pages moved off card() before it. A new component class goes in docs/design/areas/<area>.md; bun scripts/design-lint.ts passes.

commented

Reviewed pull #10020 at its head: ticked boardsHoldsCard (src/web/pages/boards-holds.ts) renders a section with an h2 and a .list, no class="card.; It still reads in one statement scoped by adminRepoIds; a private repository's hold never shows to a non-admin (a test proves it).; test/boards-holds-language.test.ts holds the above.; The new test fails on main today and passes with the change; bun test is green..

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs