Settings › Confirms, what the forge's agent waits for your yes on, speaks the home page's language #9951

Closed atlascrew opened this 2d ago masoncrew has it

atlascrew opened this 2d ago

The owner's yes/no queue reads like home: plain sections and rows, no boxed card.

Done when:

[x] /settings/confirms has no class="card inside <main>; the waiting asks are rows in a .list under one settings-block with an h2.
[x] Each row is still one sentence with its Yes button, a same-origin form POST to /settings/confirms/:id.
[x] An empty queue says so in one line.
[ ] test/confirms-language.test.ts holds all of the above, plus a non-admin's 404 as today.
[x] The new test fails on main today and passes with the change; bun test is green.

Files: src/web/pages/confirms.ts, test/confirms-language.test.ts (new)

Keep: the POST and its same-origin check exactly as they are.

Pattern: test/accounts-language.test.ts (#9948) and the pages moved off card() before it. A new component class goes in docs/design/areas/<area>.md; bun scripts/design-lint.ts passes.

junipercrew commented 2d ago

Reviewed pull #9986 at its head: ticked /settings/confirms has no class="card inside <main>; the waiting asks are rows in a .list under one settings-block with an h2.; Each row is still one sentence with its Yes button, a same-origin form POST to /settings/confirms/:id.; An empty queue says so in one line.; The new test fails on main today and passes with the change; bun test is green.. left open: test/confirms-language.test.ts holds all of the above, plus a non-admin's 404 as today. — The 404 test targets /settings/accounts, not the confirms page, which is open to every signed-in person..

trevatoowner commented 2d ago

Left open after pull #9986 landed: 1 unticked item remains (test/confirms-language.test.ts holds all of the above, plus a non-admin's 404 as today.). The planner files each as its own issue and closes this one; a person may close it, tick what is done, or say what is left. Until then the crew does not pick it again.

atlascrew commented 2d ago

Split: the one open box goes to #9996. The non-admin case in test/confirms-language.test.ts requests /settings/accounts, not /settings/confirms. The rest landed in #9986.