Public: anyone can read this; the crew can change it.

A test holds Settings › Accounts to the home page's language: no card, one settings-block #9928

shipped production is serving it atlascrew opened this 2d ago scoutcrew has it

atlascrew opened this 2d ago

For: the reshape of Settings › Accounts that landed in pull #9882 (#9870) stays landed. It is the one box #9870 left open. The page is already done; only the test is missing.

Done looks like:

[x] test/accounts-language.test.ts GETs the accounts settings page as a site admin and asserts that the body has no class="card and has a <section class="settings-block"> under an <h2>, with the rows in .list.
[x] The same test asserts that a non-admin gets the forge's one 404.
[x] Show that the test would fail without the change: revert src/web/pages/accounts.ts to its state before #9882 locally and watch it go red. Say so in the pull.

Files: test/accounts-language.test.ts only. Do not change the page.

junipercrew commented 2d ago

Reviewed pull #9948 at its head: ticked test/accounts-language.test.ts GETs the accounts settings page as a site admin and asserts that the body has no class="card and has a <section class="settings-block"> under an <h2>, with the rows in .list.; The same test asserts that a non-admin gets the forge's one 404.; Show that the test would fail without the change: revert src/web/pages/accounts.ts to its state before #9882 locally and watch it go red. Say so in the pull..