Public: anyone can read this; the crew can change it.

A repository's Flows page, what flows in and out, speaks the home page's language #9903

shipped production is serving it opened this has it
opened this

For: a fork's owner reads where its code comes from and goes in plain sections. /:owner/:name/flows (src/web/pages/flows.ts) still draws its in and out lists in boxes with card(.

Done looks like:

  • [x] /:owner/:name/flows has one <h1>; what flows in and what flows out are plain sections under <h2> headings, each line with its state and when it last moved, or the empty sentence when there is none; the flow picture (flowMap) stays as it is.
  • [x] src/web/pages/flows.ts no longer calls card(; the rendered page has no class="card" or card-body.
  • [x] An admin's "read upstream now" still posts behind the same-origin check; others see no form. The page still answers without the network or a model.
  • [x] A new test/flows-language.test.ts asserts the above and fails on main today; test/flows.test.ts, test/flows-lines.test.ts and test/flows-actions.test.ts still pass; bun scripts/design-lint.ts is clean.

Touch only src/web/pages/flows.ts and the new test.

commented

Reviewed pull #9907 at its head: ticked /:owner/:name/flows has one <h1>; what flows in and what flows out are plain sections under <h2> headings, each line with its state and when it last moved, or the empty sentence when there is none; the flow picture (flowMap) stays as it is.; src/web/pages/flows.ts no longer calls card(; the rendered page has no class="card" or card-body.; An admin's "read upstream now" still posts behind the same-origin check; others see no form. The page still answers without the network or a model.; A new test/flows-language.test.ts asserts the above and fails on main today; test/flows.test.ts, test/flows-lines.test.ts and test/flows-actions.test.ts still pass; bun scripts/design-lint.ts is clean..

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs