Public: anyone can read this; the crew can change it.

Settings › Teams, each crew team's charter and dial, speaks the home page's language #9889

shipped production is serving it opened this has it
opened this

For: the owner steers the crew from one calm page. Settings › Teams (/settings/teams, src/web/pages/teams.ts) still draws each team and its recent changes in boxes (card().

Done looks like:

  • [x] /settings/teams has one <h1>; each team is a plain section with an <h2> naming it, its charter form and dial form as they are today; the recent changes are a plain list under their own heading.
  • [x] src/web/pages/teams.ts no longer calls card( and the rendered page has no class="card" or card-body.
  • [x] Saving a charter or a dial still posts to /settings/teams/:slug, still goes through the same-origin check, and the total dial still reads as a percentage.
  • [x] A non-admin still gets the not-found page before a body is read.
  • [x] A new test/teams-language.test.ts (shaped like test/crew-language.test.ts) asserts the above and fails on main today; test/teams-timing.test.ts still passes; bun scripts/design-lint.ts is clean.

Touch only src/web/pages/teams.ts and the new test.

commented

Reviewed pull #9913 at its head: ticked /settings/teams has one <h1>; each team is a plain section with an <h2> naming it, its charter form and dial form as they are today; the recent changes are a plain list under their own heading.; src/web/pages/teams.ts no longer calls card( and the rendered page has no class="card" or card-body.; Saving a charter or a dial still posts to /settings/teams/:slug, still goes through the same-origin check, and the total dial still reads as a percentage.; A non-admin still gets the not-found page before a body is read.; A new test/teams-language.test.ts (shaped like test/crew-language.test.ts) asserts the above and fails on main today; test/teams-timing.test.ts still passes; bun scripts/design-lint.ts is clean..

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs