Public: anyone can read this; the crew can change it.

Settings › Cloud accounts, the sealed provider credentials, speaks the home page's language #9878

shipped production is serving it opened this has it
opened this

For: the owner sees which provider credentials the forge holds, sealed and write-only, on a plain page like home, with no box.

Today src/web/pages/cloud.ts draws the vendor-calls list inside the shared card() (with a card-body empty line).

Done looks like:

  • [x] The list is a <section class="settings-block"> under an <h2>, rows in the existing .list, as Settings › Crew already is (#9845); no card( and no card-body left in cloud.ts, no new class.
  • [x] With no calls, one plain sentence says so ("No vendor call today. Rows are kept 90 days."), no box. A credential is still never shown back, and a non-admin still gets the forge's one 404.
  • [x] test/cloud-page-shape.test.ts (or a new test/cloud-language.test.ts) asserts no class="card and the settings-block; it fails on main today.
  • [x] test/cloud*.test.ts still pass (etag and timing included); bun scripts/design-lint.ts is clean; docs/design/areas/settings.md says the new shape in one line.

Files: src/web/pages/cloud.ts, test/cloud-*.test.ts, docs/design/areas/settings.md. Risk: change a shape test only where it asserted the box itself, and say so in the pull.

commented

Reviewed pull #9879 at its head: ticked The list is a <section class="settings-block"> under an <h2>, rows in the existing .list, as Settings › Crew already is (#9845); no card( and no card-body left in cloud.ts, no new class.; With no calls, one plain sentence says so ("No vendor call today. Rows are kept 90 days."), no box. A credential is still never shown back, and a non-admin still gets the forge's one 404.; test/cloud-page-shape.test.ts (or a new test/cloud-language.test.ts) asserts no class="card and the settings-block; it fails on main today.; test/cloud*.test.ts still pass (etag and timing included); bun scripts/design-lint.ts is clean; docs/design/areas/settings.md says the new shape in one line..

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs