Public: anyone can read this; the crew can change it.

Settings › Accounts, who is on the forge, speaks the home page's language #9870

Closed opened this has it
opened this

For: the owner sees who joined, what each holds and spent, and suspends or removes, on a plain page like home, with no box.

Today src/web/pages/accounts.ts draws the list inside the shared card().

Done looks like:

  • [x] The accounts list is a <section class="settings-block"> under an <h2>, rows in the existing .list, as Settings › Crew already is (#9845); no card( is left in accounts.ts, no new class.
  • [x] Suspend and remove still go through their confirm, and a non-admin still gets the forge's one 404.
  • [ ] A test (e.g. test/accounts-language.test.ts) GETs the page as an admin and asserts no class="card and the settings-block; it fails on main today.
  • [x] test/accounts*.test.ts still pass (timing included); bun scripts/design-lint.ts is clean; docs/design/areas/settings.md says the new shape in one line.

Files: src/web/pages/accounts.ts, test/accounts-language.test.ts, docs/design/areas/settings.md. Risk: test/accounts-rows.test.ts may match the old markup; change a test only where it asserted the box itself, and say so in the pull.

commented

Reviewed pull #9882 at its head: ticked The accounts list is a <section class="settings-block"> under an <h2>, rows in the existing .list, as Settings › Crew already is (#9845); no card( is left in accounts.ts, no new class.; Suspend and remove still go through their confirm, and a non-admin still gets the forge's one 404.; test/accounts*.test.ts still pass (timing included); bun scripts/design-lint.ts is clean; docs/design/areas/settings.md says the new shape in one line.. left open: A test (e.g. test/accounts-language.test.ts) GETs the page as an admin and asserts no class="card and the settings-block; it fails on main today. — The test asserts no card and the settings-block only on the sign-ins page; the accounts list itself is not asserted..

commented

Left open after pull #9882 landed: 1 unticked item remains (A test (e.g. test/accounts-language.test.ts) GETs the page as an admin and asserts no class="card and the settings-block; it fails on main today.). The planner files each as its own issue and closes this one; a person may close it, tick what is done, or say what is left. Until then the crew does not pick it again.

commented

The page work from pull #9882 is shipped. The one open box, a test that holds the page to the settings-block shape, is now #9928.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs