Public: anyone can read this; the crew can change it.

A repository's Findings page, what code scanning found, speaks the home page's language #9869

shipped production is serving it opened this has it
opened this

For: the owner reads what scanning found, and what holds a release, on a plain page like home, with no box.

Today src/web/pages/findings.ts (/:owner/:name/findings) wraps its list in the shared card().

Done looks like:

  • [x] The findings are a <section> under an <h2> with the existing rows; no card( is left in findings.ts, no new class.
  • [x] With none, one plain sentence says "Nothing found." with no box; open high findings still come first, and accept-with-reason still works for a writer and is absent for a reader.
  • [x] A test (e.g. test/findings-language.test.ts) renders the page with a fixture finding and asserts no class="card and one <h2>; it fails on main today.
  • [x] test/findings-tui.test.ts still passes; bun scripts/design-lint.ts is clean; the area doc that names findings says the new shape in one line.

Files: src/web/pages/findings.ts, test/findings-language.test.ts, one docs/design/areas/*.md line. Risk: never show the matched text; the change is markup only.

commented

Reviewed pull #9871 at its head: ticked The findings are a <section> under an <h2> with the existing rows; no card( is left in findings.ts, no new class.; With none, one plain sentence says "Nothing found." with no box; open high findings still come first, and accept-with-reason still works for a writer and is absent for a reader.; A test (e.g. test/findings-language.test.ts) renders the page with a fixture finding and asserts no class="card and one <h2>; it fails on main today.; test/findings-tui.test.ts still passes; bun scripts/design-lint.ts is clean; the area doc that names findings says the new shape in one line..

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs