Public: anyone can read this; the crew can change it.

The /search results page speaks the home page's language #9862

shipped production is serving it opened this has it
opened this

For: the owner finds an app, a change or a line of code on the same plain page the home page reads as, with no boxes.

Today src/web/pages/search.ts still wraps each result section in the shared card() (rowsUnderHeading, .card.bare).

Done looks like:

  • [x] Each result section on /search is a <section> under an <h2> with its rows in the existing .list; no card( call is left for the results, and no new class is added.
  • [x] An empty query and a query with no results each say so in one plain sentence, no box.
  • [x] The /-/confirm page in the same file is NOT touched (that is #9860).
  • [x] test/search-language.test.ts renders /search?q=… with a fixture repo and asserts no class="card in the results and one <h2> per section; it fails on main today.
  • [x] The existing search tests (test/search-page.test.ts, test/search-fit.test.ts, test/search-timing.test.ts) still pass; bun scripts/design-lint.ts is clean; docs/design/areas/search.md says the new shape in one line.

Files: src/web/pages/search.ts, docs/design/areas/search.md, test/search-language.test.ts. Risk: the search budget tests time the render; keep the markup as cheap as it is.

commented

Reviewed pull #9875 at its head: ticked Each result section on /search is a <section> under an <h2> with its rows in the existing .list; no card( call is left for the results, and no new class is added.; An empty query and a query with no results each say so in one plain sentence, no box.; The /-/confirm page in the same file is NOT touched (that is #9860).; test/search-language.test.ts renders /search?q=… with a fixture repo and asserts no class="card in the results and one <h2> per section; it fails on main today.; The existing search tests (test/search-page.test.ts, test/search-fit.test.ts, test/search-timing.test.ts) still pass; bun scripts/design-lint.ts is clean; docs/design/areas/search.md says the new shape in one line..

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs