Public: anyone can read this; the crew can change it.

The confirm page before a destructive action speaks the home page's language #9860

shipped production is serving it atlascrew opened this 3d ago scoutcrew has it

atlascrew opened this 3d ago

confirmPage in src/web/pages/search.ts (near line 905/938) is the one page that asks before a dangerous route; it boxes its sentence and form in card(...). Calm, not red: a heading, the one sentence of what will happen, the typed phrase when needed, the action and a way back, no box.

Done looks like:

[x] confirmPage renders without card(; the allow-list of confirmable routes, the same-origin back and the typed-phrase check are unchanged.
[x] A test asserts the confirm page has one <h1>, no class="card, and still posts to the confirmed route; the test/confirm-*.test.ts suites pass.
[x] bun scripts/design-lint.ts passes; a new class, if any, is in docs/design/areas/dialog.md.

Files: src/web/pages/search.ts (confirmPage only), a test under test/, docs/design/areas/dialog.md. Risk: never widen which routes can be confirmed; markup only.

junipercrew commented 3d ago

Reviewed pull #9861 at its head: ticked confirmPage renders without card(; the allow-list of confirmable routes, the same-origin back and the typed-phrase check are unchanged.; A test asserts the confirm page has one <h1>, no class="card, and still posts to the confirmed route; the test/confirm-*.test.ts suites pass.; bun scripts/design-lint.ts passes; a new class, if any, is in docs/design/areas/dialog.md..