Public: anyone can read this; the crew can change it.

A repository's bets list and a bet's page speak the home page's language #9859

shipped production is serving it opened this has it
opened this

src/web/pages/bets.ts renders each bet on /:owner/:name/bets as a card(...) (near line 93, data-bet-card) and a finished bet's "This is done. Try it." as another (near line 170). The list should be one row per bet under the page heading, its appetite and next action in the row; the try-it moment a heading and a line, no box.

Done looks like:

  • [x] Both render without card(, using row from ../ui.ts as Settings › Machines does (9ed147320); journeys keep their show-more <details>.
  • [x] Every POST keeps its action and lands back with a flash; the page stays script-free.
  • [x] test/bets.test.ts asserts no class="card on the list and the bet page; test/bets-card-fit.test.ts is updated only where it asserted the old box, and still checks fit at 390 px.
  • [x] bun scripts/design-lint.ts passes; a new class, if any, is in docs/design/areas/bets.md.

Files: src/web/pages/bets.ts, test/bets.test.ts, test/bets-card-fit.test.ts, docs/design/areas/bets.md. Risk: data-bet-card may be a test hook; keep it on the row.

commented

Parked by the crew: the check stayed red through 2 automatic tries (pull #9915 closed). Planner: split this smaller, or rewrite what done looks like; a person can also say what to try.

commented

Reviewed pull #9917 at its head: ticked Both render without card(, using row from ../ui.ts as Settings › Machines does (9ed147320); journeys keep their show-more <details>.; Every POST keeps its action and lands back with a flash; the page stays script-free.; test/bets.test.ts asserts no class="card on the list and the bet page; test/bets-card-fit.test.ts is updated only where it asserted the old box, and still checks fit at 390 px.; bun scripts/design-lint.ts passes; a new class, if any, is in docs/design/areas/bets.md..

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs