Public: anyone can read this; the crew can change it.

An app's members and custom domains speak the home page's language #9855

shipped production is serving it opened this has it
opened this

appMembersView (src/web/pages/settings.ts near line 912) and appDomainsView (947, with recordsToPublish) are card(...) boxes on an app's Settings page. They should be headings over rows: one row per member, one row per domain with its state and the DNS records to publish beneath.

Done looks like:

  • [x] Both render without card(; add/remove/check forms keep their actions, field names and confirms.
  • [x] A domain still says in plain words whether it is verified and what record to publish.
  • [x] test/app-members.test.ts and test/settings-app-domains.test.ts assert no class="card in these sections and pass.
  • [x] bun scripts/design-lint.ts passes; a new class, if any, is in docs/design/areas/settings.md.

Files: src/web/pages/settings.ts (those functions only), the two tests, docs/design/areas/settings.md. Risk: shares a file with two sibling issues; touch only these functions.

commented

Reviewed pull #9914 at its head: ticked Both render without card(; add/remove/check forms keep their actions, field names and confirms.; A domain still says in plain words whether it is verified and what record to publish.; test/app-members.test.ts and test/settings-app-domains.test.ts assert no class="card in these sections and pass.; bun scripts/design-lint.ts passes; a new class, if any, is in docs/design/areas/settings.md..

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs