Public: anyone can read this; the crew can change it.

An app's settings form, visitors and environment names speak the home page's language #9854

shipped production is serving it opened this has it
opened this

On an app's Settings page, appSettingsView (src/web/pages/settings.ts near line 652/768), appVisitorsView (789) and appEnvView (824) are each a card(...) box. A zero-technical owner reads this page; it should read like the home page.

Done looks like:

  • [x] These three views render without card(: a heading, one sentence, rows or the form, in the settings-block shape of Settings › Machines (9ed147320).
  • [x] Env values are still never shown, only names; every form keeps its action and field names.
  • [x] A test (test/app-env.test.ts or a new test/app-settings-page.test.ts) asserts these sections carry no class="card; test/app-settings-timing.test.ts passes.
  • [x] bun scripts/design-lint.ts passes; a new class, if any, is in docs/design/areas/settings.md.

Files: src/web/pages/settings.ts (those three functions only), a test, docs/design/areas/settings.md. Risk: shares a file with the repository-settings and app-members issues; touch only these functions.

commented

Reviewed pull #9874 at its head: ticked These three views render without card(: a heading, one sentence, rows or the form, in the settings-block shape of Settings › Machines (9ed147320).; Env values are still never shown, only names; every form keeps its action and field names.; A test (test/app-env.test.ts or a new test/app-settings-page.test.ts) asserts these sections carry no class="card; test/app-settings-timing.test.ts passes.; bun scripts/design-lint.ts passes; a new class, if any, is in docs/design/areas/settings.md..

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs