Public: anyone can read this; the crew can change it.

A repository's Settings › General speaks the home page's language #9853

shipped production is serving it opened this has it
opened this

settingsPage in src/web/pages/settings.ts boxes each section in card(...): Branch and gates (near line 272), the wave cut (381), Archive (395, 417) and Provenance (provenanceCard, 549). Settings › Machines (9ed147320) shows the shape to follow: a settings-block heading, one plain sentence, rows, no box.

Done looks like:

  • [x] Those sections render without card(; every form keeps its action, method, field names and ids.
  • [x] Archive stays one line where it belongs with its confirm, never a banner.
  • [x] test/settings.test.ts asserts the General page carries no class="card and each form still posts where it did; test/settings-repo-timing.test.ts passes.
  • [x] bun scripts/design-lint.ts passes; a new class, if any, is in docs/design/areas/settings.md.

Files: src/web/pages/settings.ts (settingsPage and provenanceCard only), test/settings.test.ts, docs/design/areas/settings.md. Risk: the app-settings views in the same file are other issues; leave them untouched to avoid conflicting pulls.

commented

Reviewed pull #9865 at its head: ticked Those sections render without card(; every form keeps its action, method, field names and ids.; Archive stays one line where it belongs with its confirm, never a banner.; test/settings.test.ts asserts the General page carries no class="card and each form still posts where it did; test/settings-repo-timing.test.ts passes.; bun scripts/design-lint.ts passes; a new class, if any, is in docs/design/areas/settings.md..

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs