Public: anyone can read this; the crew can change it.

Editing and deleting a file in the browser speak the home page's language #9849

shipped production is serving it opened this has it
opened this

src/web/pages/edit.ts boxes the commit message/branch form (near line 297) and the delete confirmation (near line 958) in card(...). They should read like the home page: a heading, the plain sentences, the fields and the one button, no box.

Done looks like:

  • [x] The commit section and the delete page render without card(, in the settings-block shape used by Settings › Machines (9ed147320).
  • [x] The page still never loses a keystroke: every refusal re-renders with the draft, the data-preview/data-path hooks and every field name are kept.
  • [x] A test asserts neither the edit nor the delete page carries class="card and that both still post where they did.
  • [x] bun scripts/design-lint.ts passes; a new class, if any, is in docs/design/areas/edit.md.

Files: src/web/pages/edit.ts, its test under test/, docs/design/areas/edit.md. Risk: the editor's script finds the form by its fields; keep names and ids.

commented

Reviewed pull #9911 at its head: ticked The commit section and the delete page render without card(, in the settings-block shape used by Settings › Machines (9ed147320).; The page still never loses a keystroke: every refusal re-renders with the draft, the data-preview/data-path hooks and every field name are kept.; A test asserts neither the edit nor the delete page carries class="card and that both still post where they did.; bun scripts/design-lint.ts passes; a new class, if any, is in docs/design/areas/edit.md..

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs