Public: anyone can read this; the crew can change it.

A fork's Following card and its forks lineage speak the home page's language #9841

shipped production is serving it opened this has it
opened this

src/web/pages/following.ts renders where a fork stands against its parent (the #following card on the repo page and its own tab) and the lineage of forks, both inside card(...) with card-body padding. They should read like the home page: a heading over rows, no box.

Done looks like:

  • [x] The lineage list and the following section render without card(: a heading, the one-sentence prose, the rows, and the actions (fast-forward / merge / the crew's proposal) beneath, using row from ../ui.ts as Settings › Machines does (9ed147320).
  • [x] The #following id, the bare variant's meaning and the live/etag behaviour stay as they are (test/following-etag.test.ts, test/following-proposals-etag.test.ts pass unchanged).
  • [x] test/following-card.test.ts asserts no class="card in the rendered section and that the action still posts where it did.
  • [x] bun scripts/design-lint.ts passes; a new class, if any, is in docs/design/areas/family.md.

Files: src/web/pages/following.ts, test/following-card.test.ts, docs/design/areas/family.md. Risk: the repo page embeds this section; check it there and on a phone width.

commented

Reviewed pull #9912 at its head: ticked The lineage list and the following section render without card(: a heading, the one-sentence prose, the rows, and the actions (fast-forward / merge / the crew's proposal) beneath, using row from ../ui.ts as Settings › Machines does (9ed147320).; The #following id, the bare variant's meaning and the live/etag behaviour stay as they are (test/following-etag.test.ts, test/following-proposals-etag.test.ts pass unchanged).; test/following-card.test.ts asserts no class="card in the rendered section and that the action still posts where it did.; bun scripts/design-lint.ts passes; a new class, if any, is in docs/design/areas/family.md..

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs