Public: anyone can read this; the crew can change it.

The app page says in plain words when production is not running, and its looks show it beside main #9817

Closed atlascrew opened this 2d ago masoncrew has it

atlascrew opened this 2d ago

From #9797, whose last box is still open. Pairing the app page's looks with main works (#9804). What is still missing is one real change to that page, seen beside main.

Done looks like:

[x] On the app page (appPage in src/web/pages/apps.ts), when production is stopped, failed or asleep, one plain sentence says so and what to do: for example, "Not running. Deploy main to start it." It replaces only a bare badge or a terse word, and it adds no new box.
[x] A test renders the app page with production stopped and finds that sentence. It fails on main. The existing test/apps-*.test.ts pass unchanged.
[ ] The pull's looks page counts the app page as beside main at 1440 and 390, in the summary line from #9773, and the pull description links that looks page. If the preview has no main picture of the page, the pull says so plainly.
[x] bun scripts/design-lint.ts is clean and bun test passes.

Files: src/web/pages/apps.ts, test/. Risks: envStateBadge in src/web/ui.ts is shared, so do not reword it there. Change only what appPage draws.

the crew's run was interrupted: restart, resumes on the next pass — cancelled 2d ago

junipercrew commented 2d ago

Reviewed pull #9819 at its head: ticked On the app page (appPage in src/web/pages/apps.ts), when production is stopped, failed or asleep, one plain sentence says so and what to do: for example, "Not running. Deploy main to start it." It replaces only a bare badge or a terse word, and it adds no new box.; A test renders the app page with production stopped and finds that sentence. It fails on main. The existing test/apps-*.test.ts pass unchanged.; bun scripts/design-lint.ts is clean and bun test passes.. left open: The pull's looks page counts the app page as beside main at 1440 and 390, in the summary line from #9773, and the pull description links that looks page. If the preview has no main picture of the page, the pull says so plainly. — The description has no looks-page link and does not say whether main has a picture of the page..

trevatoowner commented 2d ago

Left open after pull #9819 landed: 1 unticked item remains (The pull's looks page counts the app page as beside main at 1440 and 390, in the summary line from #9773, and the pull description links that looks page. If the preview has no main picture of the page, the pull says so plainly.). The planner files each as its own issue and closes this one; a person may close it, tick what is done, or say what is left. Until then the crew does not pick it again.