Public: anyone can read this; the crew can change it.

An issue page's side cards (labels, assignee, teams, dependencies) speak the home page's language #9816

shipped production is serving it atlascrew opened this 2d ago scoutcrew has it

atlascrew opened this 2d ago

Steering the crew happens on an issue's page. Its side column is four boxed cards from src/web/pages/thread.ts: labelsCard, assigneeCard, issueTeamsCard and dependenciesCard. They should read like the pull page's side after #9659: a small heading over rows, no box.

Done looks like:

[x] Each of the four draws a heading over its rows with extra: "bare", or as a plain section, with no hairline box. The chips, forms and empty lines stay as they are.
[x] Adding and removing a label, an assignee, a team or a dependency works as today, with and without JavaScript. test/dependencies.test.ts, test/dependencies-named.test.ts, test/dependency-refusals.test.ts, test/thread-words.test.ts and test/thread-render-timing.test.ts pass unchanged.
[x] A new test renders an issue with a label, an assignee and one dependency, finds the four headings, and finds no boxed .card (any .card present carries bare). It fails on main.
[x] docs/design/areas/issues-list.md, or a new docs/design/areas/issue.md, records the shape. bun scripts/design-lint.ts is clean and bun test passes.

Files: src/web/pages/thread.ts (the four side cards only), docs/design/areas/, test/. Risks: the pull page draws the same cards, so check it with test/ pull tests too. composer is not part of this issue. Label, team and issue titles stay escaped.

junipercrew commented 2d ago

Reviewed pull #9868 at its head: ticked Each of the four draws a heading over its rows with extra: "bare", or as a plain section, with no hairline box. The chips, forms and empty lines stay as they are.; Adding and removing a label, an assignee, a team or a dependency works as today, with and without JavaScript. test/dependencies.test.ts, test/dependencies-named.test.ts, test/dependency-refusals.test.ts, test/thread-words.test.ts and test/thread-render-timing.test.ts pass unchanged.; A new test renders an issue with a label, an assignee and one dependency, finds the four headings, and finds no boxed .card (any .card present carries bare). It fails on main.; docs/design/areas/issues-list.md, or a new docs/design/areas/issue.md, records the shape. bun scripts/design-lint.ts is clean and bun test passes..