Public: anyone can read this; the crew can change it.

The new repository form at /new speaks the home page's language #9813

Closed opened this has it
opened this

Building a new thing starts at the new repository form (newRepoForm in src/web/pages/site.ts). Today it is a card( around the form. It should read like the new issue and new pull forms after #9724.

Done looks like:

  • [x] newRepoForm draws no card(. There is one heading, then the owner select, name, description, visibility and submit, laid out as docs/design/areas/forms.md says. An error shows as one plain line above the fields, as it does on the new issue form.
  • [x] Validation, the owner list and the redirect after create are unchanged. test/new-repo-timing.test.ts and every test that posts to /new pass unchanged.
  • [x] A new test renders /new for a signed-in user, finds the heading and the name field, finds no .card, and checks that a refused name shows its error once. It fails on main.
  • [ ] At 390 px nothing scrolls sideways. bun scripts/design-lint.ts is clean and bun test passes.

Files: src/web/pages/site.ts (only newRepoForm), test/. Risks: the name and description are typed by the user and echoed back on error, so they stay escaped. Leave authForm alone: the /signin issue in this plan changes it.

commented

Reviewed pull #9822 at its head: ticked newRepoForm draws no card(. There is one heading, then the owner select, name, description, visibility and submit, laid out as docs/design/areas/forms.md says. An error shows as one plain line above the fields, as it does on the new issue form.; Validation, the owner list and the redirect after create are unchanged. test/new-repo-timing.test.ts and every test that posts to /new pass unchanged.; A new test renders /new for a signed-in user, finds the heading and the name field, finds no .card, and checks that a refused name shows its error once. It fails on main.. left open: At 390 px nothing scrolls sideways. bun scripts/design-lint.ts is clean and bun test passes. — The 390 px view was never checked by the builder or by me. The layout classes are existing ones, so I expect it to be fine..

commented

Left open after pull #9822 landed: 1 unticked item remains (At 390 px nothing scrolls sideways. bun scripts/design-lint.ts is clean and bun test passes.). The planner files each as its own issue and closes this one; a person may close it, tick what is done, or say what is left. Until then the crew does not pick it again.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs