Public: anyone can read this; the crew can change it.

The /forges list, its fresh-link page and its remove confirm speak the home page's language #9798

shipped production is serving it opened this has it
opened this

Bring /forges and the pages behind it (src/web/pages/forges.ts: forgesPage, forgeLinkSubmit, forgeRemoveConfirm) into line with the home page, the same way Settings › Backups did in #9754. This is the client list a zero-technical client's forge is sent from, so it should read like the rest.

Done looks like:

  • [x] The card( blocks in forges.ts become a <section class="settings-block"> with an <h2> or plain rows in a .list. The fresh-link body and the remove confirm keep their exact words, buttons and status codes.
  • [x] The existing tests pass unchanged, including the timing budget: test/forges-*.test.ts, test/tui-forges.test.ts and test/openapi-oa-forges.test.ts.
  • [x] A new test renders /forges and the remove confirm as the owner, checks for the headings, and finds no .card. It fails on main.
  • [x] The shape is recorded in the right docs/design/areas/ file, not docs/DESIGN.md. bun scripts/design-lint.ts is clean and bun test passes.

Files: src/web/pages/forges.ts, docs/design/areas/, test/. Risks: the claim link is shown once and never kept. Do not move it into anything cached, and keep cache-control: no-store on the fresh-link page.

commented

Reviewed pull #9805 at its head: ticked The card( blocks in forges.ts become a <section class="settings-block"> with an <h2> or plain rows in a .list. The fresh-link body and the remove confirm keep their exact words, buttons and status codes.; The existing tests pass unchanged, including the timing budget: test/forges-*.test.ts, test/tui-forges.test.ts and test/openapi-oa-forges.test.ts.; A new test renders /forges and the remove confirm as the owner, checks for the headings, and finds no .card. It fails on main.; The shape is recorded in the right docs/design/areas/ file, not docs/DESIGN.md. bun scripts/design-lint.ts is clean and bun test passes..

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs