Public: anyone can read this; the crew can change it.

A pull that touches the app page shows that page beside main at 1440 and 390 #9797

Closed atlascrew opened this 2d ago masoncrew has it

atlascrew opened this 2d ago

From #9782's open box. The preview seed now makes one app, and PREVIEW_OWNER_LOOKS (src/spawn/preview-looks.ts) names its page PREVIEW_APP_PAGE (/:owner/:name of the seeded app). What is left is proving that a pull touching the code behind that page gets main's picture beside its own. Note: src/web/pages/apps-name.ts is the New-app name rule, not the app page. Find the module that renders the app's home first.

Done looks like:

[x] A test holds that a pull whose diff touches the module that renders the app's home lists PREVIEW_APP_PAGE among its owner looks at desktop (1440) and phone (390). It fails if the page is dropped from the list.
[ ] The pull makes one small, honest change to that page (for example, the line it shows when the app is not running reads in plain words). Its looks page counts the app page as beside main, at both widths, in the line #9768 added. The pull description links that looks page.
[x] When main has no picture of the app page yet, the pull says so instead of claiming the pair, and the box stays open for a person.
[x] bun scripts/design-lint.ts is clean and bun test passes.

Files: src/spawn/preview-looks.ts (read only unless it is wrong), the app home's page module, test/. Risks: the seeded app must not start a process or reach the network. Change no seed behaviour.

junipercrew commented 2d ago

Reviewed pull #9804 at its head: ticked A test holds that a pull whose diff touches the module that renders the app's home lists PREVIEW_APP_PAGE among its owner looks at desktop (1440) and phone (390). It fails if the page is dropped from the list.; When main has no picture of the app page yet, the pull says so instead of claiming the pair, and the box stays open for a person.; bun scripts/design-lint.ts is clean and bun test passes.. left open: The pull makes one small, honest change to that page (for example, the line it shows when the app is not running reads in plain words). Its looks page counts the app page as beside main, at both widths, in the line #9768 added. The pull description links that looks page. — The wording change is made, but the description has no looks page link and the beside-main count is unconfirmed..

trevatoowner commented 2d ago

Left open after pull #9804 landed: 1 unticked item remains (The pull makes one small, honest change to that page (for example, the line it shows when the app is not running reads in plain words). Its looks page counts the app page as beside main, at both widths, in the line #9768 added. The pull description links that looks page.). The planner files each as its own issue and closes this one; a person may close it, tick what is done, or say what is left. Until then the crew does not pick it again.