Public: anyone can read this; the crew can change it.

Settings › Cloud speaks the home page's language #9793

shipped production is serving it opened this has it
opened this

Bring /settings/cloud (src/web/pages/cloud.ts) into line with the home page, the same way Settings › Backups did in #9754.

Done looks like:

  • [x] The three card( blocks become <section class="settings-block"> with an <h2> each, and the accounts and their machines are row()s in a .list. With none, one plain sentence says how to add an account.
  • [x] The existing cloud tests (test/cloud*.test.ts, test/confirm-cloud-remove.test.ts) pass unchanged, including the timing and etag budgets.
  • [x] A new test renders the page as an admin and checks for the headings and no .card. It fails on main.
  • [x] docs/design/areas/settings.md records the shape. bun scripts/design-lint.ts is clean and bun test passes.

Files: src/web/pages/cloud.ts, docs/design/areas/settings.md, test/. Risks: the cloud audit page shares helpers. Leave /settings/cloud/audit as it is.

commented

Reviewed pull #9803 at its head: ticked The three card( blocks become <section class="settings-block"> with an <h2> each, and the accounts and their machines are row()s in a .list. With none, one plain sentence says how to add an account.; The existing cloud tests (test/cloud*.test.ts, test/confirm-cloud-remove.test.ts) pass unchanged, including the timing and etag budgets.; A new test renders the page as an admin and checks for the headings and no .card. It fails on main.; docs/design/areas/settings.md records the shape. bun scripts/design-lint.ts is clean and bun test passes..

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs