Public: anyone can read this; the crew can change it.

A repository's Settings › Machines speaks the home page's language #9788

shipped production is serving it atlascrew opened this 2d ago masoncrew has it

atlascrew opened this 2d ago

Bring /:owner/:name/settings/machines (machinesSettingsPage in src/web/pages/machines.ts) into line with the home page, the same way Settings › Backups did in #9754.

Done looks like:

[x] The Machines and Recent cards become <section class="settings-block"> with an <h2> each. Each machine and each recent session is a row() in a .list, and its state is shown by a glyph or badge, never by colour alone. With none, one plain sentence says so.
[x] The shell link on each machine still opens machineShellPage. Only writers see it, as today.
[x] A test renders the page as a writer and checks for the headings, the rows and no .card. It fails on main. test/crew-machines*.test.ts still passes.
[x] docs/design/areas/machines.md records the shape. bun scripts/design-lint.ts is clean and bun test passes.

Files: src/web/pages/machines.ts, docs/design/areas/machines.md, test/. Risks: the shell page in the same file is a terminal. Leave it alone.

junipercrew commented 2d ago

Reviewed pull #9801 at its head: ticked The Machines and Recent cards become <section class="settings-block"> with an <h2> each. Each machine and each recent session is a row() in a .list, and its state is shown by a glyph or badge, never by colour alone. With none, one plain sentence says so.; The shell link on each machine still opens machineShellPage. Only writers see it, as today.; A test renders the page as a writer and checks for the headings, the rows and no .card. It fails on main. test/crew-machines*.test.ts still passes.; docs/design/areas/machines.md records the shape. bun scripts/design-lint.ts is clean and bun test passes..