Public: anyone can read this; the crew can change it.

Settings › Origins speaks the home page's language #9787

shipped production is serving it opened this has it
opened this

Bring Settings › Origins (/settings/origins, src/web/pages/origins.ts) into line with the home page, the same way Settings › Backups did in #9754.

Done looks like:

  • [x] The three card( blocks in src/web/pages/origins.ts become <section class="settings-block"> with an <h2> each, and the connected origins and their repositories are row()s in a .list. When there are none, one plain sentence says how to connect one.
  • [x] Connecting, importing and removing an origin still work. The existing origins tests (test/origins-*.test.ts) pass unchanged.
  • [x] A new test renders the page and checks for the headings and no .card. It fails on main.
  • [x] accountSections (also used by backups.ts) keeps its signature.
  • [x] docs/design/areas/ records the shape. bun scripts/design-lint.ts is clean and bun test passes.

Files: src/web/pages/origins.ts, docs/design/areas/settings.md, test/. Risks: origins.ts is long and shares helpers with other settings pages. Change only the markup.

commented

Reviewed pull #9802 at its head: ticked The three card( blocks in src/web/pages/origins.ts become <section class="settings-block"> with an <h2> each, and the connected origins and their repositories are row()s in a .list. When there are none, one plain sentence says how to connect one.; Connecting, importing and removing an origin still work. The existing origins tests (test/origins-*.test.ts) pass unchanged.; A new test renders the page and checks for the headings and no .card. It fails on main.; accountSections (also used by backups.ts) keeps its signature.; docs/design/areas/ records the shape. bun scripts/design-lint.ts is clean and bun test passes..

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs