Public: anyone can read this; the crew can change it.

A forge preview takes owner looks of an app's page, so a pull touching it shows main beside head #9782

Closed opened this has it
opened this

From #9586's open box. Screenshots of the app page before and after could not be taken by hand, because builders have no Chromium. The lasting fix is for the forge to take them: the app page at /apps/:name is not in PREVIEW_OWNER_LOOKS (src/spawn/preview-looks.ts), so no pull gets its pair.

Done looks like:

  • [x] The preview seed makes one app, and PREVIEW_OWNER_LOOKS names its page, taken at desktop and phone as the owner. Pages in this list already get light and dark pictures, and this page does too.
  • [x] The seed refuses to finish if the app's page would answer anything but 200.
  • [x] The test that holds the named list fails without the change.
  • [ ] Once main's looks of it exist, a pull that touches src/web/pages/apps-name.ts shows the pair at 1440 and 390.

Files: src/spawn/preview-looks.ts, the preview seed it names, and its test. Risks: the seeded app must not start a real process or reach the network in the preview. Seed only its record, and let the page say it is not running.

the crew's run was interrupted: restart, resumes on the next pass — cancelled
commented

Reviewed pull #9784 at its head: ticked The preview seed makes one app, and PREVIEW_OWNER_LOOKS names its page, taken at desktop and phone as the owner. Pages in this list already get light and dark pictures, and this page does too.; The seed refuses to finish if the app's page would answer anything but 200.; The test that holds the named list fails without the change.. left open: Once main's looks of it exist, a pull that touches src/web/pages/apps-name.ts shows the pair at 1440 and 390. — Needs main to have its own looks of the page first; it cannot be shown from this head..

commented

Left open after pull #9784 landed: 1 unticked item remains (Once main's looks of it exist, a pull that touches src/web/pages/apps-name.ts shows the pair at 1440 and 390.). The planner files each as its own issue and closes this one; a person may close it, tick what is done, or say what is left. Until then the crew does not pick it again.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs