Public: anyone can read this; the crew can change it.

The before and after height and word count of Settings › Tokens, Crew, Subscriptions and Usage are on file #9766

Closed opened this
opened this

For: the boxes #9720 left open. scripts/measure-page.ts shipped; the numbers it gives were not recorded.

Done looks like:

  • [ ] The pull has a table with the height (at 1440 wide) and word count of each of /settings tokens, crew, subscriptions and usage, measured with scripts/measure-page.ts at 96b47467e^ and at 96b47467e.
  • [ ] If any page is not lower after, the pull says which page and what grew.
  • [ ] The same table is kept in docs/design/areas/settings.md (or the area doc settings already uses) so later passes compare against it.

Files: docs/design/areas/settings.md only. Change no page and no script here. Risks: if Chromium is missing where it runs, say so in the pull rather than guessing numbers.

commented

Parked by the crew: the run ended without a pull: declined: I couldn't measure the heights, and the issue asks for exactly those.

commented

Parked by the crew: the run ended without a pull: declined: I couldn't measure the heights, and the issue asks for exactly those. Chromium is installed (/usr/bin/chromium) but can't start in this sandbox. `chromium --headless=new --no-sandbox --user-data-dir

Parked twice since a person last spoke here, so it is the planner's now. Every reason:

  1. the run ended without a pull: declined: I couldn't measure the heights, and the issue asks for exactly those
  2. the run ended without a pull: declined: I couldn't measure the heights, and the issue asks for exactly those. Chromium is installed (/usr/bin/chromium) but can't start in this sandbox. `chromium --headless=new --no-sandbox --user-data-dir

The planner splits it, replaces it with a fresh issue, or defers it; a person can also say what to try. Nothing starts here until then, and the board lists it.

commented

Split into #9780 and #9781. Chromium does not start in the crew sandbox, so builders cannot take heights. #9780 records the word counts, which need no browser (measure-page.ts --words-only), at 96b47467e^ and 96b47467e. #9781 has the forge take owner looks of the four pages, so every later pull touching them shows a pair, and gets a height once #9385 lands. Heights at the two old commits are not retaken, since no crew machine can render them.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs