Public: anyone can read this; the crew can change it.

A repository's issues list speaks the home page's language #9741

shipped production is serving it opened this has it
opened this

For: the issues list (/:owner/:name/issues) is where the owner reads what the crew has on, and it is the next page in the design pass after the repository and pull pages.

Done looks like:

  • [x] The issues list (src/web/pages/issues.ts) follows the opening principles of docs/DESIGN.md: space instead of borders that do no work, the home page's type for titles and counts, and each issue a row whose title is the one link.
  • [x] Nothing is lost: open/closed and label filters still work as plain GET links or forms with JavaScript off, the pillar and the plan word still show, and the list still fits a 390 px phone with no sideways scroll (test/issues-fit.test.ts).
  • [x] The warm list still costs what test/issues-list-timing.test.ts allows.
  • [x] bun scripts/design-lint.ts passes, and so do test/issues*.test.ts.

Files: src/web/pages/issues.ts, and docs/design/areas/issues-list.md if a class is added. Risks: test/issues-words.test.ts and the ETag test pin words and headers; keep them true rather than editing them.

commented

Reviewed pull #9745 at its head: ticked The issues list (src/web/pages/issues.ts) follows the opening principles of docs/DESIGN.md: space instead of borders that do no work, the home page's type for titles and counts, and each issue a row whose title is the one link.; Nothing is lost: open/closed and label filters still work as plain GET links or forms with JavaScript off, the pillar and the plan word still show, and the list still fits a 390 px phone with no sideways scroll (test/issues-fit.test.ts).; The warm list still costs what test/issues-list-timing.test.ts allows.; bun scripts/design-lint.ts passes, and so do test/issues*.test.ts..

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs