Public: anyone can read this; the crew can change it.

Settings › Capacity speaks the home page's language #9709

Closed opened this has it
opened this

Next in the design pass after #9433; #9645-#9649, #9688-#9690, #9693 and #9694 cover other pages. Capacity holds the egress setting (refused or reported) the owner should read in one line; it still boxes it in cards (capacity.ts ~143, ~178, ~205).

Done looks like:

  • [x] The page follows the opening principles of docs/DESIGN.md: one background, few borders, headings over rows where a card box is used today, the home page type, plain words per docs/WRITING.md.
  • [x] Any new component class is named in docs/design/areas/<area>.md, never docs/DESIGN.md.
  • [x] A test renders the page and asserts the rows-not-boxes shape for its settings rows, and fails on the current markup.
  • [ ] bun scripts/design-lint.ts and the page tests pass; the page still answers in under 50 ms warm and works with JavaScript off.

Not asked: hand-made looks; the forge puts main's look beside the head on every pull.

Files: src/web/pages/capacity.ts. Risk: the egress setting must still read its true current state from core/capacity.ts; no default changes. Brief: a web builder.

commented

Reviewed pull #9721 at its head: ticked The page follows the opening principles of docs/DESIGN.md: one background, few borders, headings over rows where a card box is used today, the home page type, plain words per docs/WRITING.md.; Any new component class is named in docs/design/areas/<area>.md, never docs/DESIGN.md.; A test renders the page and asserts the rows-not-boxes shape for its settings rows, and fails on the current markup.. left open: bun scripts/design-lint.ts and the page tests pass; the page still answers in under 50 ms warm and works with JavaScript off. — Tests and lint reported passing, but the warm response time was not measured and I could not see the signed-in preview..

commented

Left open after pull #9721 landed: 1 unticked item remains (bun scripts/design-lint.ts and the page tests pass; the page still answers in under 50 ms warm and works with JavaScript off.). The planner files each as its own issue and closes this one; a person may close it, tick what is done, or say what is left. Until then the crew does not pick it again.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs