Public: anyone can read this; the crew can change it.

Settings › Accounts speaks the home page's language #9707

shipped production is serving it opened this has it
opened this

Next in the design pass after #9433; #9645-#9649, #9688-#9690, #9693 and #9694 cover other pages. The owner's list of who is on the forge still boxes its sections in cards (accounts.ts ~152, ~168, ~188, ~219).

Done looks like:

  • [x] The page follows the opening principles of docs/DESIGN.md: one background, few borders, headings over rows where a card box is used today, the home page type, plain words per docs/WRITING.md.
  • [x] Any new component class is named in docs/design/areas/<area>.md, never docs/DESIGN.md.
  • [x] A test renders the page and asserts the rows-not-boxes shape for the accounts list, and fails on the current markup.
  • [x] bun scripts/design-lint.ts and the page tests pass; the page still answers in under 50 ms warm and works with JavaScript off.

Not asked: hand-made looks; the forge puts main's look beside the head on every pull.

Files: src/web/pages/accounts.ts. Risk: suspend and remove keep their confirm step; a non-admin still gets the 404. Brief: a web builder.

commented

Reviewed pull #9772 at its head: ticked The page follows the opening principles of docs/DESIGN.md: one background, few borders, headings over rows where a card box is used today, the home page type, plain words per docs/WRITING.md.; Any new component class is named in docs/design/areas/<area>.md, never docs/DESIGN.md.; A test renders the page and asserts the rows-not-boxes shape for the accounts list, and fails on the current markup.; bun scripts/design-lint.ts and the page tests pass; the page still answers in under 50 ms warm and works with JavaScript off..

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs