Public: anyone can read this; the crew can change it.

When a pull lands, its head's looks are kept as main's looks for each page, width and theme #9668

shipped production is serving it opened this has it
opened this

For: every "looks before and after" box. Agents cannot attach pictures (src/actions/attach_look.ts) and the forge only photographs a pull's head, so these boxes stay open on every design pull (#9584, #9587, #9595, #9634).

Done looks like:

  • [x] When a pull merges, the looks taken at its head (each page, kind and theme from src/looks/service.ts) are recorded as main's current look for that page, kind and theme, in the forge's database or under its data directory. A later landing replaces them.
  • [x] A function in src/looks/ returns main's look for a page, kind and theme, or nothing.
  • [x] A test lands two pulls with looks for the same page and shows the second replaces the first. A page only the first photographed keeps the first's look.
  • [x] No page changes in this pull.

Files: src/looks/service.ts or a new src/looks/main_looks.ts, its test, the land path that already sweeps a pull's environment. Risk: the pull's environment folder is swept at close, so keep a reference or a copy before the sweep. Do not keep every head's looks, only main's latest.

commented

Reviewed pull #9672 at its head: ticked When a pull merges, the looks taken at its head (each page, kind and theme from src/looks/service.ts) are recorded as main's current look for that page, kind and theme, in the forge's database or under its data directory. A later landing replaces them.; A function in src/looks/ returns main's look for a page, kind and theme, or nothing.; A test lands two pulls with looks for the same page and shows the second replaces the first. A page only the first photographed keeps the first's look.; No page changes in this pull..

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs