Public: anyone can read this; the crew can change it.

Settings › Tokens, Crew, Subscriptions and Usage have before/after height, word count and looks on file #9662

Closed opened this has it
opened this

For: proof that the rewrite in 96b47467e (#9583) made each page measurably shorter. The rewrite shipped without the numbers. Do not redo the pages.

Done looks like:

  • [ ] For each of the four pages, at 96b47467e^ and at 96b47467e: the rendered height at 1440 wide (Chromium document.documentElement.scrollHeight) and the word count of main's text. A table in the pull, with all four lower after.
  • [ ] If any page is not lower, file one issue naming it and what grew. Do not change it here.
  • [ ] Looks at 1440 and 390, light and dark, after, attached to the pull.
  • [x] bun test passes.

Files: optionally a small scripts/measure-page.ts (height and word count for a path), which may be reused; otherwise only the pull description. Risk: the pages need an admin session. Use the fixture sign-in the tests already use.

commented

Reviewed pull #9679 at its head: ticked bun test passes.. left open: For each of the four pages, at 96b47467e^ and at 96b47467e: the rendered height at 1440 wide (Chromium document.documentElement.scrollHeight) and the word count of main's text. A table in the pull, with all four lower after. — Word counts are on file and all lower, but no heights were measured: Chromium would not start in the builder's sandbox.; If any page is not lower, file one issue naming it and what grew. Do not change it here. — Without heights it is unknown whether any page grew taller, so this cannot be settled.; Looks at 1440 and 390, light and dark, after, attached to the pull. — No pictures are attached. The --shots option exists but has not been run..

commented

Left open after pull #9679 landed: 3 unticked items remain (For each of the four pages, at 96b47467e^ and at 96b47467e: the rendered height at 1440 wide (Chromium document.documentElement.scrollHeight) and the word count of main's text. A table in the pull, with all four lower after.; If any page is not lower, file one issue naming it and what grew. Do not change it here.; Looks at 1440 and 390, light and dark, after, attached to the pull.). The planner files each as its own issue and closes this one; a person may close it, tick what is done, or say what is left. Until then the crew does not pick it again.

commented

Closing. The four pages shipped in 96b47467e. The boxes left are a table of past heights and word counts, plus looks of the result. The looks are what #9669 makes automatic. A one-off measurement of shipped work does not change what anyone builds next, so it is not worth a builder run.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs