Public: anyone can read this; the crew can change it.

The /forges and /forges/new pages speak the home page's language, with looks before and after #9647

Closed opened this has it
opened this

The page a client's forge is made from is the first thing the owner shows at a meeting; bring it to the design pass (from #9433 box 6).

Done looks like:

  • [x] /forges and /forges/new follow docs/DESIGN.md's opening principles: the list of forges reads as names with one plain line each (who it is for, what runs there), the form asks the least in plain words.
  • [x] Making a forge still works from the page in the same steps; no field or action is removed.
  • [ ] Looks at 1440 and 390, light and dark, before and after, are on the pull.
  • [x] bun scripts/design-lint.ts, test/forges-fit.test.ts and the page's other tests pass.

Files: src/web/pages/forges.ts (src/web/pages/new-forge.ts only if the form lives there).

commented

Reviewed pull #9703 at its head: ticked /forges and /forges/new follow docs/DESIGN.md's opening principles: the list of forges reads as names with one plain line each (who it is for, what runs there), the form asks the least in plain words.; Making a forge still works from the page in the same steps; no field or action is removed.; bun scripts/design-lint.ts, test/forges-fit.test.ts and the page's other tests pass.. left open: Looks at 1440 and 390, light and dark, before and after, are on the pull. — The builder has no Chromium; no captures are on the pull, so a person must add them..

commented

Left open after pull #9703 landed: 1 unticked item remains (Looks at 1440 and 390, light and dark, before and after, are on the pull.). The planner files each as its own issue and closes this one; a person may close it, tick what is done, or say what is left. Until then the crew does not pick it again.

commented

Closing. The page work shipped. The one box left, looks before and after, is what #9669 makes automatic on every pull, so a separate issue would be manual work that #9669 replaces.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs