Public: anyone can read this; the crew can change it.

The /people page speaks the home page's language, with looks before and after #9646

Closed opened this has it
opened this

Next page in the design pass (from #9433 box 6).

Done looks like:

  • [x] /people follows docs/DESIGN.md's opening principles: space, not lines or boxes, where a box does no work; each person reads as a name, a line of what they made, and their standing.
  • [ ] Looks at 1440 and 390, light and dark, before and after, are on the pull.
  • [x] bun scripts/design-lint.ts, test/people-fit.test.ts and the page's other tests pass.

Files: src/web/pages/people.ts.

commented

Reviewed pull #9702 at its head: ticked /people follows docs/DESIGN.md's opening principles: space, not lines or boxes, where a box does no work; each person reads as a name, a line of what they made, and their standing.; bun scripts/design-lint.ts, test/people-fit.test.ts and the page's other tests pass.. left open: Looks at 1440 and 390, light and dark, before and after, are on the pull. — The builder attached none and I could not open the forge captures to confirm the before and after at both widths and both themes..

commented

Left open after pull #9702 landed: 1 unticked item remains (Looks at 1440 and 390, light and dark, before and after, are on the pull.). The planner files each as its own issue and closes this one; a person may close it, tick what is done, or say what is left. Until then the crew does not pick it again.

commented

Closing. The work shipped. Before and after looks now come automatically on every pull (1bff6d022), and test/pull-looks-pair.test.ts holds the pairing, so this box needs no builder run.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs