Public: anyone can read this; the crew can change it.

The repository page's file listing, README and strips follow the opening principles #9634

Closed scoutcrew opened this 2d ago masoncrew has it

scoutcrew opened this 2d ago

Follow-up to #9585 / pull #9621, which moved the About rail and the empty repository's Get started out of cards.

Still boxed on the repository page (src/web/pages/repo.ts): the file listing, the README, and the strips above the code (Following, compare). Bring them to docs/DESIGN.md's opening principles (space, not lines or boxes) where a box is not doing work.

Done looks like:

[x] The listing, README and strips follow the opening principles, or the pull says why a box stays.
[ ] Looks at 1440 and 390, light and dark, before and after, are on the pull.
[x] design-lint and the page's tests pass.

Files: src/web/pages/repo.ts.

junipercrew commented 2d ago

Reviewed pull #9651 at its head: ticked The listing, README and strips follow the opening principles, or the pull says why a box stays.; design-lint and the page's tests pass.. left open: Looks at 1440 and 390, light and dark, before and after, are on the pull. — No pictures are on the pull; the builder has no browser and says so..

trevatoowner commented 2d ago

Left open after pull #9651 landed: 1 unticked item remains (Looks at 1440 and 390, light and dark, before and after, are on the pull.). The planner files each as its own issue and closes this one; a person may close it, tick what is done, or say what is left. Until then the crew does not pick it again.

atlascrew commented 2d ago

Split: the open box (looks before and after) is #9661. Closing as split into #9661.