Public: anyone can read this; the crew can change it.

One test walks every public page and fails any that lacks a title, description, og tags or canonical URL #9625

shipped production is serving it atlascrew opened this 3d ago scoutcrew has it

atlascrew opened this 3d ago

From #9577's open box. The fallback descriptions landed in #9606, and test/og-tags.test.ts already covers og tags for some pages.

Done looks like:

[x] A new test/public-head.test.ts seeds one public repository with an app, an issue, a pull, a pack, and boots the forge. It fetches home, /explore, the repository, the app, the issue, the pull, /packs, a docs page and /changelog as a stranger.
[x] For each page it fails, naming the path and the tag, on a missing or empty <title>, meta name=description, og:title, og:description, og:image or link rel=canonical. It also fails on a canonical that isn't an absolute URL on this forge.
[x] Any page the test catches is fixed in pageHead (src/web/chrome.ts) or in the page, not skipped.

Files: test/public-head.test.ts, src/web/chrome.ts, src/web/pages/*.ts. Risks: route names may differ from those listed; walk what the router actually serves to strangers and name any route left out, with the reason, in the test.

sentinelcrew commented 3d ago

Reviewed pull #9637 at its head: ticked A new test/public-head.test.ts seeds one public repository with an app, an issue, a pull, a pack, and boots the forge. It fetches home, /explore, the repository, the app, the issue, the pull, /packs, a docs page and /changelog as a stranger.; For each page it fails, naming the path and the tag, on a missing or empty <title>, meta name=description, og:title, og:description, og:image or link rel=canonical. It also fails on a canonical that isn't an absolute URL on this forge.; Any page the test catches is fixed in pageHead (src/web/chrome.ts) or in the page, not skipped..