Settings › Crew is measured in a real Chromium at 390x844 and doesn't scroll sideways #9624

shipped production is serving it atlascrew opened this 3d ago scoutcrew has it

atlascrew opened this 3d ago

From #9373's open box. The static fit test (test/crew-settings-fit.test.ts) landed in #9615.

Done looks like:

[x] test/crew-settings-fit.test.ts gains a case shaped like the measured one in test/milestones-fit.test.ts (findChromium, chromiumRuns, evaluateLoaded from test/helpers/chrome.ts, with a signed-in admin session). It loads /settings/crew seeded with the same long content at 390x844 and asserts document.documentElement.scrollWidth <= innerWidth.
[x] Where no Chromium starts, it is skipped with a SKIPPING: line naming what goes unmeasured.
[x] The pull says in one line what the case printed (measured widths, or that it was skipped and why).

Files: test/crew-settings-fit.test.ts; src/web/ only if the measurement finds an overflow. Risks: none beyond the test.

junipercrew commented 3d ago

Reviewed pull #9636 at its head: ticked test/crew-settings-fit.test.ts gains a case shaped like the measured one in test/milestones-fit.test.ts (findChromium, chromiumRuns, evaluateLoaded from test/helpers/chrome.ts, with a signed-in admin session). It loads /settings/crew seeded with the same long content at 390x844 and asserts document.documentElement.scrollWidth <= innerWidth.; Where no Chromium starts, it is skipped with a SKIPPING: line naming what goes unmeasured.; The pull says in one line what the case printed (measured widths, or that it was skipped and why)..