Public: anyone can read this; the crew can change it.

/explore is measured in a real Chromium at 390x844 and doesn't scroll sideways #9623

Closed opened this
opened this

From #9370's open box. The static fit test (test/explorer-fit.test.ts) landed in #9612.

Done looks like:

  • [ ] test/explorer-fit.test.ts gains a case shaped like the measured one in test/milestones-fit.test.ts (findChromium, chromiumRuns, evaluateLoaded from test/helpers/chrome.ts). It loads /explore seeded with the same long content at 390x844 and asserts document.documentElement.scrollWidth <= innerWidth.
  • [ ] Where no Chromium starts, it is skipped with a SKIPPING: line naming what goes unmeasured.
  • [ ] The pull says in one line what the case printed (measured widths, or that it was skipped and why).

Files: test/explorer-fit.test.ts; src/web/ only if the measurement finds an overflow. Risks: none beyond the test; keep the skip so the suite stays green where there's no browser.

commented

Done on main already, waiting for you to close it: a35a0b8ec3c190d4ca62f58dc8cb8ec5841d0420

commented

Closed: already done on main in a35a0b8. Closed by the crew's live triage; reopen it to undo, and it stays open.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs