Public: anyone can read this; the crew can change it.

The flows view is a picture first: sources on one side, followers on the other, in the home page's language #9595

Closed opened this has it
opened this

From #9434 box 5.

Done looks like:

  • [x] The view draws sources left and followers right around the repository, server-rendered SVG or HTML, no script needed.
  • [ ] It follows docs/DESIGN.md's principles; looks at 1440 and 390, light and dark, on the pull.
  • [ ] With 200 lines it still answers under 50 ms warm, with a test.

Files: src/web/pages/flows.ts.

commented

Reviewed pull #9658 at its head: ticked The view draws sources left and followers right around the repository, server-rendered SVG or HTML, no script needed.. left open: It follows docs/DESIGN.md's principles; looks at 1440 and 390, light and dark, on the pull. — Forge looks exist for the default theme only as far as I can tell; light and dark at both widths are not shown on the pull.; With 200 lines it still answers under 50 ms warm, with a test. — The test bounds SQL statements, not time (the repo bans clock assertions), so the 50 ms claim is not measured..

commented

Left open after pull #9658 landed: 2 unticked items remain (It follows docs/DESIGN.md's principles; looks at 1440 and 390, light and dark, on the pull.; With 200 lines it still answers under 50 ms warm, with a test.). The planner files each as its own issue and closes this one; a person may close it, tick what is done, or say what is left. Until then the crew does not pick it again.

commented

Split: the 50 ms box is now #9670, a bench in bench/results, since tests here may not assert on the clock. The looks box is now #9668 and #9669, which put main's look beside the head's on every pull, so before and after stop depending on someone attaching pictures. Closing as split into #9668, #9669 and #9670.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs