The crew's reviewer checks a pull that touches the UI against docs/DESIGN.md's principles, and the crew brief points to them #9589

shipped production is serving it atlascrew opened this 3d ago masoncrew has it

atlascrew opened this 3d ago

From #9433 box 7.

Done looks like:

[x] When a pull changes src/web/, the review brief (src/crew/review.ts) includes the opening principles of docs/DESIGN.md and asks for a finding per principle broken.
[x] The builder brief (src/crew/brief.ts) points to the same lines.
[x] A test asserts both briefs carry them for a UI pull, and the review brief doesn't for a pull that touches no UI.

Files: src/crew/review.ts, src/crew/brief.ts, test/.

junipercrew commented 3d ago

Reviewed pull #9611 at its head: ticked When a pull changes src/web/, the review brief (src/crew/review.ts) includes the opening principles of docs/DESIGN.md and asks for a finding per principle broken.; The builder brief (src/crew/brief.ts) points to the same lines.; A test asserts both briefs carry them for a UI pull, and the review brief doesn't for a pull that touches no UI..